[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <f07cb96e-9a0a-4a29-91e8-6975e1a2df00@lunn.ch>
Date: Sat, 22 Jun 2024 20:37:37 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Kamil Horák (2N) <kamilh@...s.com>
Cc: florian.fainelli@...adcom.com, bcm-kernel-feedback-list@...adcom.com,
hkallweit1@...il.com, linux@...linux.org.uk, davem@...emloft.net,
edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org,
netdev@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v9 2/4] net: phy: bcm54811: Add LRE registers definitions
On Fri, Jun 21, 2024 at 01:26:31PM +0200, Kamil Horák (2N) wrote:
> Add the definitions of LRE registers for Broadcom BCM5481x PHY
>
> Signed-off-by: Kamil Horák (2N) <kamilh@...s.com>
> Reviewed-by: Florian Fainelli <florian.fainelli@...adcom.com>
> ---
> include/linux/brcmphy.h | 89 +++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 89 insertions(+)
>
> diff --git a/include/linux/brcmphy.h b/include/linux/brcmphy.h
> index 1394ba302367..ae39c33e4086 100644
> --- a/include/linux/brcmphy.h
> +++ b/include/linux/brcmphy.h
> @@ -270,6 +270,86 @@
> #define BCM5482_SSD_SGMII_SLAVE 0x15 /* SGMII Slave Register */
> #define BCM5482_SSD_SGMII_SLAVE_EN 0x0002 /* Slave mode enable */
> #define BCM5482_SSD_SGMII_SLAVE_AD 0x0001 /* Slave auto-detection */
> +#define BCM5482_SSD_SGMII_SLAVE_AD 0x0001 /* Slave auto-detection */
That looks odd. Is there something subtle i'm not seeing here?
Andrew
Powered by blists - more mailing lists