netdev - Re: octeontx2-af: Fix klockwork issues in AF driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <6217cc19-9aa4-48e2-85ef-2bbe4c0d8189@web.de>
Date: Sun, 23 Jun 2024 08:48:59 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Suman Ghosh <sumang@...vell.com>, netdev@...r.kernel.org,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Geethasowjanya Akula <gakula@...vell.com>,
 Hariprasad Kelam <hkelam@...vell.com>, Jakub Kicinski <kuba@...nel.org>,
 Jerin Jacob <jerinj@...vell.com>, Linu Cherian <lcherian@...vell.com>,
 Paolo Abeni <pabeni@...hat.com>,
 Subbaraya Sundeep Bhatta <sbhatta@...vell.com>,
 Sunil Kovvuri Goutham <sgoutham@...vell.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Julia Lawall <julia.lawall@...ia.fr>
Subject: Re: octeontx2-af: Fix klockwork issues in AF driver

> I guess that there is a need to split different change possibilities
> into separate update steps.
…
> This is the first time I have submitted for klockwork fixes.
>
> Since these are similar klockwork fixes based on variable declaration and NULL checks.

Did this source code analysis tool present items according to different
development concerns (from selected categories)?

> I thought of combining the same.

Would you like to take the known advice “Solve only one problem per patch”
better into account?
Please take another look at further approaches for the presentation of
similar “change combinations”.

> Do you suggest 2 separate patch one for variable declaration and one for NULL checks?

Probably, yes.

> Or do I need to submit patch per file?

Maybe.

You can dare to offer software updates for each concern category
as patch series.
You can adapt then also better for constraints according to the selection of tags
(like “Fixes” and “Cc”), can't you?

Regards,
Markus