netdev - Re: [PATCH] s390/netiucv: handle memory allocation failure in conn_action

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bb03a384-b2c4-438f-b36b-a4af33a95b60@web.de>
Date: Sun, 23 Jun 2024 16:27:31 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Yunseong Kim <yskelg@...il.com>, linux-s390@...r.kernel.org,
 netdev@...r.kernel.org, Alexander Gordeev <agordeev@...ux.ibm.com>,
 Alexandra Winter <wintera@...ux.ibm.com>,
 Christian Bornträger <borntraeger@...ux.ibm.com>,
 Heiko Carstens <hca@...ux.ibm.com>, Sven Schnelle <svens@...ux.ibm.com>,
 Thorsten Winkler <twinkler@...ux.ibm.com>, Vasily Gorbik <gor@...ux.ibm.com>
Cc: LKML <linux-kernel@...r.kernel.org>, MichelleJin <shjy180909@...il.com>
Subject: Re: [PATCH] s390/netiucv: handle memory allocation failure in
 conn_action_start()

> This patch handle potential null pointer dereference in
> iucv_path_connect(), When iucv_path_alloc() fails to allocate memory
> for 'rc'.

1. Can a wording approach (like the following) be a better change description?

   A null pointer is stored in the data structure member “path” after a call
   of the function “iucv_path_alloc” failed. This pointer was passed to
   a subsequent call of the function “iucv_path_connect” where an undesirable
   dereference will be performed then.
   Thus add a corresponding return value check.

2. May the proposed error message be omitted
   (because a memory allocation failure might have been reported
   by an other function call already)?

3. Is there a need to adjust the return type of the function “conn_action_start”?

4. Would you like to add any tags (like “Fixes”) accordingly?

5. Under which circumstances will development interests grow for increasing
   the application of scope-based resource management?
   https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/cleanup.h#L8

Regards,
Markus