[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID:
<AS2P194MB2170A39251AC72302E8F6F459ACB2@AS2P194MB2170.EURP194.PROD.OUTLOOK.COM>
Date: Sun, 23 Jun 2024 17:04:17 +0200
From: Luigi Leonardi <luigi.leonardi@...look.com>
To: sgarzare@...hat.com
Cc: davem@...emloft.net,
edumazet@...gle.com,
jasowang@...hat.com,
kuba@...nel.org,
kvm@...r.kernel.org,
luigi.leonardi@...look.com,
mst@...hat.com,
netdev@...r.kernel.org,
pabeni@...hat.com,
stefanha@...hat.com,
virtualization@...ts.linux.dev,
xuanzhuo@...ux.alibaba.com
Subject: Re: [PATCH net-next v2 2/3] vsock/virtio: add SIOCOUTQ support for all virtio based transports
Hi Paolo and Stefano,
Sorry for the (super) late reply! I haven't had much time to work on
it, I hope to send a v3 by the end of this month! Thanks both of you
for your comments and reviews! :)
> > This will add 2 atomic operations per packet, possibly on contended
> > cachelines. Have you considered leveraging the existing transport-level
> > lock to protect the counter updates?
> Good point!
> Maybe we can handle it together with `tx_cnt` in
> virtio_transport_get_credit()/virtio_transport_put_credit().
> WDYT?
I'll take a look at it! That's a very good idea.
> Should virtio_transport_bytes_unsent() returns size_t?
Yes! int was because of atomic_int, size_t is more appropriate.
Thanks,
Luigi
Powered by blists - more mailing lists