netdev - Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b023dfb3-ca8e-4045-b0b1-d6e498961e9c@genexis.eu>
Date: Mon, 24 Jun 2024 01:01:44 +0200
From: Benjamin Larsson <benjamin.larsson@...exis.eu>
To: Andrew Lunn <andrew@...n.ch>, Lorenzo Bianconi <lorenzo@...nel.org>
Cc: netdev@...r.kernel.org, nbd@....name, lorenzo.bianconi83@...il.com,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, conor@...nel.org, linux-arm-kernel@...ts.infradead.org,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, conor+dt@...nel.org,
 devicetree@...r.kernel.org, catalin.marinas@....com, will@...nel.org,
 upstream@...oha.com, angelogioacchino.delregno@...labora.com,
 rkannoth@...vell.com, sgoutham@...vell.com
Subject: Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support
 for EN7581 SoC

Hi,
> Code like this is making me wounder about the split between MAC
> driver, DSA driver and DSA tag driver. Or if it should actually be a
> pure switchdev driver?
>
> If there some open architecture documentation for this device?
>
> What are these ports about?
>
>> +static int airoha_dev_open(struct net_device *dev)
>> +{
>> +	struct airoha_eth *eth = netdev_priv(dev);
>> +	int err;
>> +
>> +	if (netdev_uses_dsa(dev))
>> +		airoha_fe_set(eth, REG_GDM1_INGRESS_CFG, GDM1_STAG_EN_MASK);
>> +	else
>> +		airoha_fe_clear(eth, REG_GDM1_INGRESS_CFG, GDM1_STAG_EN_MASK);
> Does that imply both instances of the GMAC are not connected to the
> switch? Can one be used with a PHY?
>
> 	Andrew

https://mirror2.openwrt.org/docs/MT7981B_Wi-Fi6_Platform_Datasheet_Open_V1.0.pdf

page 107 (text for 9.1.1 is relevant but not a complete match). In the 
EN7581 case there is a 5 port switch in the place of GMAC1 (one switch 
port is connected to GDM1).

This is documentation for another SoC but it should hopefully answer 
your questions.

MvH

Benjamin Larsson