| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <20240624113122.12732-1-antonio@openvpn.net> Date: Mon, 24 Jun 2024 13:30:57 +0200 From: Antonio Quartulli <antonio@...nvpn.net> To: netdev@...r.kernel.org Cc: kuba@...nel.org, ryazanov.s.a@...il.com, pabeni@...hat.com, edumazet@...gle.com, andrew@...n.ch, sd@...asysnail.net, Antonio Quartulli <antonio@...nvpn.net> Subject: [PATCH net-next v4 00/25] Introducing OpenVPN Data Channel Offload Hi all! here I am with v4 of the ovpn patchset! Thanks to Sabrina's feedback, several parts of the code are now simpler than before. There is an extra kernel patch, compared to v3, that is 02/25. This patch is required to properly handle virtual devices not implementing a dellink upon invocation of rtnl_unregister_ops(). Here is an overview of the changesfrom v3, sorted more or less by importance (very minor changes haven't been mentioned): * got rid of the TX/RX queues entirely * got rid of the workqueues entirely ** the only sporadic scheduled event, TCP TX retry, is scheduled on the global kernel queue * use strparser for receiving TCP data * use gro_cells and get rid of any napi and netif_rx_ring related code * crypto code now follows the classic async paradigma * removed synchronize_net() * avoided unregister_netdevice() double call * added empty rtnl_link_ops to ensure ifaces are destroyed upon ns exit * convert pkt counters to 64 bit * counted dropped packets (in core stats) * simplified peer lookup routines (no need to hold ref every time) * simplified TCP recvmsg implementation * peer collection for MultiPeer mode is now allocated dynamically * use GFP_ATOMIC for sending nl notifications out of process context * documented how EALREADY and EBUSY are used in UDP socket attach * used GENL_REQ_ATTR_CHECK in ovpn_get_dev_from_attrs/pre_doit * used NL_SET_BAD_ATTR/GENL_SET_ERR_MSG in ovpn_get_dev_from_attrs/pre_doit * used NL_SET_ERR_MSG_MOD for reporting back error strings * dropped netlink 'pad' attribute * used genlmsg_iput * set pcpu_stat_type to let core handle stats internally * used nla_put_string/in_addr/in6_addr when possibly * used ipv6 helpers when possible (ipv6_addr_equal/any) * added various calls to DEBUG_NET_WARN_ON_ONCE/WARN_ON * removed unworthy error message in case of netlink message size errors * used -EOPNOTSUPP instead of -ENOTSUPP * userspace testing tool improved * various code rearrangments based on provded feedback .. The latest code can also be found at: https://github.com/OpenVPN/linux-kernel-ovpn Below is the original description posted with the first patchest: =================================================================== `ovpn` is essentialy a device driver that allows creating a virtual network interface to handle the OpenVPN data channel. Any traffic entering the interface is encrypted, encapsulated and sent to the appropriate destination. `ovpn` requires OpenVPN in userspace to run along its side in order to be properly configured and maintained during its life cycle. The `ovpn` interface can be created/destroyed and then configured via Netlink API. Specifically OpenVPN in userspace will: * create the `ovpn` interface * establish the connection with one or more peers * perform TLS handshake and negotiate any protocol parameter * configure the `ovpn` interface with peer data (ip/port, keys, etc.) * handle any subsequent control channel communication I'd like to point out the control channel is fully handles in userspace. The idea is to keep the `ovpn` kernel module as simple as possible and let userspace handle all the non-data (non-fast-path) features. NOTE: some of you may already know `ovpn-dco` the out-of-tree predecessor of `ovpn`. However, be aware that the two are not API compatible and therefore OpenVPN 2.6 will not work with this new `ovpn` module. More adjustments are required. For more technical details please refer to the actual patches. Any comment, concern or statement will be appreciated! Thanks a lot!! Best Regards, Antonio Quartulli OpenVPN Inc. ====================== Antonio Quartulli (25): netlink: add NLA_POLICY_MAX_LEN macro rtnetlink: don't crash on unregister if no dellink exists net: introduce OpenVPN Data Channel Offload (ovpn) ovpn: add basic netlink support ovpn: add basic interface creation/destruction/management routines ovpn: implement interface creation/destruction via netlink ovpn: keep carrier always on ovpn: introduce the ovpn_peer object ovpn: introduce the ovpn_socket object ovpn: implement basic TX path (UDP) ovpn: implement basic RX path (UDP) ovpn: implement packet processing ovpn: store tunnel and transport statistics ovpn: implement TCP transport ovpn: implement multi-peer support ovpn: implement peer lookup logic ovpn: implement keepalive mechanism ovpn: add support for updating local UDP endpoint ovpn: add support for peer floating ovpn: implement peer add/dump/delete via netlink ovpn: implement key add/del/swap via netlink ovpn: kill key and notify userspace in case of IV exhaustion ovpn: notify userspace when a peer is deleted ovpn: add basic ethtool support testing/selftest: add test tool and scripts for ovpn module Documentation/netlink/specs/ovpn.yaml | 327 ++++ MAINTAINERS | 8 + drivers/net/Kconfig | 14 + drivers/net/Makefile | 1 + drivers/net/ovpn/Makefile | 22 + drivers/net/ovpn/bind.c | 58 + drivers/net/ovpn/bind.h | 119 ++ drivers/net/ovpn/crypto.c | 161 ++ drivers/net/ovpn/crypto.h | 138 ++ drivers/net/ovpn/crypto_aead.c | 347 ++++ drivers/net/ovpn/crypto_aead.h | 30 + drivers/net/ovpn/io.c | 438 +++++ drivers/net/ovpn/io.h | 21 + drivers/net/ovpn/main.c | 360 ++++ drivers/net/ovpn/main.h | 29 + drivers/net/ovpn/netlink-gen.c | 206 +++ drivers/net/ovpn/netlink-gen.h | 41 + drivers/net/ovpn/netlink.c | 958 +++++++++++ drivers/net/ovpn/netlink.h | 31 + drivers/net/ovpn/ovpnstruct.h | 52 + drivers/net/ovpn/packet.h | 40 + drivers/net/ovpn/peer.c | 1047 ++++++++++++ drivers/net/ovpn/peer.h | 202 +++ drivers/net/ovpn/pktid.c | 130 ++ drivers/net/ovpn/pktid.h | 87 + drivers/net/ovpn/proto.h | 106 ++ drivers/net/ovpn/skb.h | 56 + drivers/net/ovpn/socket.c | 165 ++ drivers/net/ovpn/socket.h | 54 + drivers/net/ovpn/stats.c | 21 + drivers/net/ovpn/stats.h | 47 + drivers/net/ovpn/tcp.c | 502 ++++++ drivers/net/ovpn/tcp.h | 42 + drivers/net/ovpn/udp.c | 404 +++++ drivers/net/ovpn/udp.h | 26 + include/net/netlink.h | 1 + include/uapi/linux/ovpn.h | 108 ++ include/uapi/linux/udp.h | 1 + net/core/rtnetlink.c | 8 +- tools/net/ynl/ynl-gen-c.py | 2 + tools/testing/selftests/Makefile | 1 + tools/testing/selftests/ovpn/Makefile | 15 + tools/testing/selftests/ovpn/config | 8 + tools/testing/selftests/ovpn/data64.key | 5 + tools/testing/selftests/ovpn/float-test.sh | 113 ++ tools/testing/selftests/ovpn/netns-test.sh | 132 ++ tools/testing/selftests/ovpn/ovpn-cli.c | 1743 ++++++++++++++++++++ tools/testing/selftests/ovpn/run.sh | 11 + tools/testing/selftests/ovpn/tcp_peers.txt | 1 + tools/testing/selftests/ovpn/udp_peers.txt | 5 + 50 files changed, 8442 insertions(+), 2 deletions(-) create mode 100644 Documentation/netlink/specs/ovpn.yaml create mode 100644 drivers/net/ovpn/Makefile create mode 100644 drivers/net/ovpn/bind.c create mode 100644 drivers/net/ovpn/bind.h create mode 100644 drivers/net/ovpn/crypto.c create mode 100644 drivers/net/ovpn/crypto.h create mode 100644 drivers/net/ovpn/crypto_aead.c create mode 100644 drivers/net/ovpn/crypto_aead.h create mode 100644 drivers/net/ovpn/io.c create mode 100644 drivers/net/ovpn/io.h create mode 100644 drivers/net/ovpn/main.c create mode 100644 drivers/net/ovpn/main.h create mode 100644 drivers/net/ovpn/netlink-gen.c create mode 100644 drivers/net/ovpn/netlink-gen.h create mode 100644 drivers/net/ovpn/netlink.c create mode 100644 drivers/net/ovpn/netlink.h create mode 100644 drivers/net/ovpn/ovpnstruct.h create mode 100644 drivers/net/ovpn/packet.h create mode 100644 drivers/net/ovpn/peer.c create mode 100644 drivers/net/ovpn/peer.h create mode 100644 drivers/net/ovpn/pktid.c create mode 100644 drivers/net/ovpn/pktid.h create mode 100644 drivers/net/ovpn/proto.h create mode 100644 drivers/net/ovpn/skb.h create mode 100644 drivers/net/ovpn/socket.c create mode 100644 drivers/net/ovpn/socket.h create mode 100644 drivers/net/ovpn/stats.c create mode 100644 drivers/net/ovpn/stats.h create mode 100644 drivers/net/ovpn/tcp.c create mode 100644 drivers/net/ovpn/tcp.h create mode 100644 drivers/net/ovpn/udp.c create mode 100644 drivers/net/ovpn/udp.h create mode 100644 include/uapi/linux/ovpn.h create mode 100644 tools/testing/selftests/ovpn/Makefile create mode 100644 tools/testing/selftests/ovpn/config create mode 100644 tools/testing/selftests/ovpn/data64.key create mode 100755 tools/testing/selftests/ovpn/float-test.sh create mode 100755 tools/testing/selftests/ovpn/netns-test.sh create mode 100644 tools/testing/selftests/ovpn/ovpn-cli.c create mode 100755 tools/testing/selftests/ovpn/run.sh create mode 100644 tools/testing/selftests/ovpn/tcp_peers.txt create mode 100644 tools/testing/selftests/ovpn/udp_peers.txt -- 2.44.2
Powered by blists - more mailing lists