netdev - Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnlwKo1tKR-wI07p@lore-desk>
Date: Mon, 24 Jun 2024 15:10:02 +0200
From: Lorenzo Bianconi <lorenzo@...nel.org>
To: Sunil Kovvuri Goutham <sgoutham@...vell.com>
Cc: "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"nbd@....name" <nbd@....name>,
	"lorenzo.bianconi83@...il.com" <lorenzo.bianconi83@...il.com>,
	"davem@...emloft.net" <davem@...emloft.net>,
	"edumazet@...gle.com" <edumazet@...gle.com>,
	"kuba@...nel.org" <kuba@...nel.org>,
	"pabeni@...hat.com" <pabeni@...hat.com>,
	"conor@...nel.org" <conor@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"robh+dt@...nel.org" <robh+dt@...nel.org>,
	"krzysztof.kozlowski+dt@...aro.org" <krzysztof.kozlowski+dt@...aro.org>,
	"conor+dt@...nel.org" <conor+dt@...nel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"will@...nel.org" <will@...nel.org>,
	"upstream@...oha.com" <upstream@...oha.com>,
	"angelogioacchino.delregno@...labora.com" <angelogioacchino.delregno@...labora.com>,
	"benjamin.larsson@...exis.eu" <benjamin.larsson@...exis.eu>,
	Ratheesh Kannoth <rkannoth@...vell.com>,
	"andrew@...n.ch" <andrew@...n.ch>
Subject: Re: [PATCH v3 net-next 2/2] net: airoha: Introduce ethernet support
 for EN7581 SoC

On Jun 24, Sunil Kovvuri Goutham wrote:
> >Add airoha_eth driver in order to introduce ethernet support for
> >Airoha EN7581 SoC available on EN7581 development board (en7581-evb).
> >en7581-evb networking architecture is composed by airoha_eth as mac
> >controller (cpu port) and a mt7530 dsa based switch.
> >EN7581 mac controller is mainly composed by Frame Engine (FE) and
> >QoS-DMA (QDMA) modules. FE is used for traffic offloading (just basic
> >functionalities are supported now) while QDMA is used for DMA operation
> >and QOS functionalities between mac layer and the dsa switch (hw QoS is
> >not available yet and it will be added in the future).
> >Currently only hw lan features are available, hw wan will be added with
> >subsequent patches.
> >
> >Tested-by: Benjamin Larsson <benjamin.larsson@...exis.eu>
> >Signed-off-by: Lorenzo Bianconi <lorenzo@...nel.org>
> >---
> >
> >+
> >+static int airoha_qdma_rx_process(struct airoha_queue *q, int budget)
> >+{
> ......................
> >+		skb->ip_summed = CHECKSUM_UNNECESSARY;
> 
> Unconditionally setting UNNECESSARY for all pkts.
> Does HW reports csum errors ?

We enabled packet drop if TCP/UDP or IPv4 checksum is failed in
REG_GDM1_FWD_CFG register in airoha_fe_maccr_init(). In other words, if the nic
forwards the packet to the cpu, the checksum is correct.

Regards,
Lorenzo

> 
> Thanks,
> Sunil.
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)