netdev - Re: [PATCH net-next 2/4] selftests: drv-net: add helper to wait for HW stats to sync

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240624074325.39c7529e@kernel.org>
Date: Mon, 24 Jun 2024 07:43:25 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 2/4] selftests: drv-net: add helper to wait for
 HW stats to sync

On Sun, 23 Jun 2024 03:37:19 -0400 Willem de Bruijn wrote:
> > +            else:
> > +                # Assume sync not required, we may use a small (50ms?) sleep
> > +                # regardless if we see flakiness
> > +                self._stats_settle_time = 0  
> 
> Intended to set _stats_settle_time to 0.05 here? Else I don't follow
> the comment

My intuition was that we will need a sleep, but I didn't see failures
in practice, so I removed it and added the comment. I'll just bring
back the sleep.