netdev - Re: [PATCH net-next 4/4] selftests: drv-net: rss_ctx: add tests for RSS configuration and contexts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240624090206.5585c2b6@kernel.org>
Date: Mon, 24 Jun 2024 09:02:06 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Willem de Bruijn <willemdebruijn.kernel@...il.com>
Cc: davem@...emloft.net, netdev@...r.kernel.org, edumazet@...gle.com,
 pabeni@...hat.com, ecree.xilinx@...il.com
Subject: Re: [PATCH net-next 4/4] selftests: drv-net: rss_ctx: add tests for
 RSS configuration and contexts

On Mon, 24 Jun 2024 07:50:35 -0700 Jakub Kicinski wrote:
> > > +    key_len = len(data['rss-hash-key'])
> > > +
> > > +    # Set the key
> > > +    key = _rss_key_rand(key_len)
> > > +    ethtool(f"-X {cfg.ifname} hkey " + _rss_key_str(key))    
> > 
> > Probably too paranoid, but in case failure is only for some randomized
> > input, is the key logged on error?  
> 
> Will add!

I take that back, if ethtool() -> tool() -> cmd() fails we'll throw 
and exception which already includes the command as well as stdout
and stderr. So we'll see in the logs what the key was.