netdev - RE: [Intel-wired-lan] [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CYYPR11MB84294D39C25D60EF07DE6451BDD42@CYYPR11MB8429.namprd11.prod.outlook.com>
Date: Mon, 24 Jun 2024 16:26:23 +0000
From: "Pucha, HimasekharX Reddy" <himasekharx.reddy.pucha@...el.com>
To: "Samal, Anil" <anil.samal@...el.com>, "intel-wired-lan@...ts.osuosl.org"
	<intel-wired-lan@...ts.osuosl.org>
CC: "netdev@...r.kernel.org" <netdev@...r.kernel.org>, "Czapnik, Lukasz"
	<lukasz.czapnik@...el.com>, "Samal, Anil" <anil.samal@...el.com>, "Pepiak,
 Leszek" <leszek.pepiak@...el.com>, "Nguyen, Anthony L"
	<anthony.l.nguyen@...el.com>, Simon Horman <horms@...nel.org>, "Kitszel,
 Przemyslaw" <przemyslaw.kitszel@...el.com>
Subject: RE: [Intel-wired-lan] [PATCH iwl-next v3 2/3] ice: Implement driver
 functionality to dump fec statistics

> -----Original Message-----
> From: Intel-wired-lan <intel-wired-lan-bounces@...osl.org> On Behalf Of Anil Samal
> Sent: Friday, June 14, 2024 6:28 PM
> To: intel-wired-lan@...ts.osuosl.org
> Cc: netdev@...r.kernel.org; Czapnik, Lukasz <lukasz.czapnik@...el.com>; Samal, Anil <anil.samal@...el.com>; Pepiak, Leszek <leszek.pepiak@...el.com>; Nguyen, Anthony L <anthony.l.nguyen@...el.com>; Simon Horman <horms@...nel.org>; Kitszel, Przemyslaw <przemyslaw.kitszel@...el.com>
> Subject: [Intel-wired-lan] [PATCH iwl-next v3 2/3] ice: Implement driver functionality to dump fec statistics
>
> To debug link issues in the field, it is paramount to dump fec corrected/uncorrected block counts from firmware.
> Firmware requires PCS quad number and PCS port number to read FEC statistics. Current driver implementation does not maintain above physical properties of a port.
>
> Add new driver API to derive physical properties of an input port.These properties include PCS quad number, PCS port number, serdes lane count, primary serdes lane number.
> Extend ethtool option '--show-fec' to support fec statistics.
> The IEEE standard mandates two sets of counters:
>  - 30.5.1.1.17 aFECCorrectedBlocks
>  - 30.5.1.1.18 aFECUncorrectableBlocks
>
> Standard defines above statistics per lane but current implementation supports total FEC statistics per port i.e. sum of all lane per port. Find sample output below
>
> FEC parameters for ens21f0np0:
> Supported/Configured FEC encodings: Auto RS BaseR Active FEC encoding: RS
> Statistics:
>   corrected_blocks: 0
>   uncorrectable_blocks: 0
>
> Reviewed-by: Simon Horman <horms@...nel.org>
> Reviewed-by: Jesse Brandeburg <jesse.brandeburg@...el.com>
> Signed-off-by: Anil Samal <anil.samal@...el.com>
> ---
>  drivers/net/ethernet/intel/ice/ice_common.c  |  57 ++++  drivers/net/ethernet/intel/ice/ice_common.h  |  24 ++  drivers/net/ethernet/intel/ice/ice_ethtool.c | 308 +++++++++++++++++++  drivers/net/ethernet/intel/ice/ice_ethtool.h |  10 +
>  drivers/net/ethernet/intel/ice/ice_type.h    |   8 +
>  5 files changed, 407 insertions(+)
>

Tested-by: Pucha Himasekhar Reddy <himasekharx.reddy.pucha@...el.com> (A Contingent worker at Intel)