netdev - Re: [PATCH net-next v7 5/9] ethtool: Veto some operations during firmware flashing process

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba8a1fac-ad41-4ac3-a3e3-8d177b78355f@lunn.ch>
Date: Mon, 24 Jun 2024 21:31:20 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Danielle Ratson <danieller@...dia.com>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
	kuba@...nel.org, pabeni@...hat.com, corbet@....net,
	linux@...linux.org.uk, sdf@...gle.com, kory.maincent@...tlin.com,
	maxime.chevallier@...tlin.com, vladimir.oltean@....com,
	przemyslaw.kitszel@...el.com, ahmed.zaki@...el.com,
	richardcochran@...il.com, shayagr@...zon.com,
	paul.greenwalt@...el.com, jiri@...nulli.us,
	linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
	mlxsw@...dia.com, idosch@...dia.com, petrm@...dia.com
Subject: Re: [PATCH net-next v7 5/9] ethtool: Veto some operations during
 firmware flashing process

On Mon, Jun 24, 2024 at 08:51:55PM +0300, Danielle Ratson wrote:
> Some operations cannot be performed during the firmware flashing
> process.
> 
> For example:
> 
> - Port must be down during the whole flashing process to avoid packet loss
>   while committing reset for example.
> 
> - Writing to EEPROM interrupts the flashing process, so operations like
>   ethtool dump, module reset, get and set power mode should be vetoed.
> 
> - Split port firmware flashing should be vetoed.
> 
> In order to veto those scenarios, add a flag in 'struct net_device' that
> indicates when a firmware flash is taking place on the module and use it
> to prevent interruptions during the process.
> 
> Signed-off-by: Danielle Ratson <danieller@...dia.com>
> Reviewed-by: Petr Machata <petrm@...dia.com>

Reviewed-by: Andrew Lunn <andrew@...n.ch>

    Andrew