netdev - Re: [PATCH v5] net/mlx5: Reclaim max 50K pages at once

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0b926745-f2c9-4313-a874-4b7e059b8d64@intel.com>
Date: Mon, 24 Jun 2024 13:41:17 -0700
From: Jesse Brandeburg <jesse.brandeburg@...el.com>
To: Anand Khoje <anand.a.khoje@...cle.com>, <linux-rdma@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <netdev@...r.kernel.org>
CC: <saeedm@...lanox.com>, <leon@...nel.org>, <tariqt@...dia.com>,
	<edumazet@...gle.com>, <kuba@...nel.org>, <pabeni@...hat.com>,
	<davem@...emloft.net>
Subject: Re: [PATCH v5] net/mlx5: Reclaim max 50K pages at once

On 6/24/2024 8:33 AM, Anand Khoje wrote:

> --- a/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/pagealloc.c
> @@ -608,6 +608,7 @@ enum {
>  	RELEASE_ALL_PAGES_MASK = 0x4000,
>  };
>  
> +#define MAX_RECLAIM_NPAGES -50000

Can you please explain why this is negative? There doesn't seem to be
any reason mentioned in the commit message or code.

At the very least it's super confusing to have a MAX be negative, and at
worst it's a bug. I don't have any other context on this code besides
this patch, so an explanation would be helpful.