netdev - Re: [PATCH] net: mana: Fix possible double free in error handling path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 24 Jun 2024 11:16:16 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Ma Ke <make24@...as.ac.cn>
CC: <linux-hyperv@...r.kernel.org>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <kys@...rosoft.com>,
	<haiyangz@...rosoft.com>, <wei.liu@...nel.org>, <decui@...rosoft.com>,
	<davem@...emloft.net>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <shradhagupta@...ux.microsoft.com>, <horms@...nel.org>,
	<kotaranov@...rosoft.com>, <linyunsheng@...wei.com>,
	<schakrabarti@...ux.microsoft.com>, <erick.archer@...look.com>
Subject: Re: [PATCH] net: mana: Fix possible double free in error handling
 path

On 6/24/24 05:21, Ma Ke wrote:
> When auxiliary_device_add() returns error and then calls
> auxiliary_device_uninit(), callback function adev_release

I would add () after function name

> calls kfree(madev) to free memory. We shouldn't call kfree(padev)

there is no `padev` in the patch :)
"to free memory" part sounds redundant.

> again in the error handling path.
> 
> Signed-off-by: Ma Ke <make24@...as.ac.cn>

you need a Fixes: tag

> ---
>   drivers/net/ethernet/microsoft/mana/mana_en.c | 31 +++++++++----------
>   1 file changed, 14 insertions(+), 17 deletions(-)
>