netdev - Re: [PATCH net-next v2 0/4] selftests: drv-net: rss

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667a8553dfe16_38c6b5294bc@willemb.c.googlers.com.notmuch>
Date: Tue, 25 Jun 2024 04:52:35 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, 
 davem@...emloft.net
Cc: netdev@...r.kernel.org, 
 edumazet@...gle.com, 
 pabeni@...hat.com, 
 willemdebruijn.kernel@...il.com, 
 ecree.xilinx@...il.com, 
 dw@...idwei.uk, 
 przemyslaw.kitszel@...el.com, 
 michael.chan@...adcom.com, 
 andrew.gospodarek@...adcom.com, 
 Jakub Kicinski <kuba@...nel.org>
Subject: Re: [PATCH net-next v2 0/4] selftests: drv-net: rss_ctx: add tests
 for RSS contexts

Jakub Kicinski wrote:
> Add a few tests exercising RSS context API.
> In addition to basic sanity checks, tests add RSS contexts,
> n-tuple rule to direct traffic to them (based on dst port),
> and qstats to make sure traffic landed where we expected.
> 
> v2 adds a test for removing contexts out of order. When testing
> bnxt - either the new test or running more tests after the overlap
> test makes the device act strangely. To the point where it may start
> giving out ntuple IDs of 0 for all rules :S
> 
> Ed, could you try the tests with your device?
> 
>   $ export NETIF=eth0 REMOTE_...
>   $ ./drivers/net/hw/rss_ctx.py
>   KTAP version 1
>   1..8
>   ok 1 rss_ctx.test_rss_key_indir
>   ok 2 rss_ctx.test_rss_context
>   ok 3 rss_ctx.test_rss_context4
>   # Increasing queue count 44 -> 66
>   # Failed to create context 32, trying to test what we got
>   ok 4 rss_ctx.test_rss_context32 # SKIP Tested only 31 contexts, wanted 32
>   ok 5 rss_ctx.test_rss_context_overlap
>   ok 6 rss_ctx.test_rss_context_overlap2
>   # .. sprays traffic like a headless chicken ..
>   not ok 7 rss_ctx.test_rss_context_out_of_order
>   ok 8 rss_ctx.test_rss_context4_create_with_cfg
>   # Totals: pass:6 fail:1 xfail:0 xpass:0 skip:1 error:0
> 
> Jakub Kicinski (4):
>   selftests: drv-net: try to check if port is in use
>   selftests: drv-net: add helper to wait for HW stats to sync
>   selftests: drv-net: add ability to wait for at least N packets to load
>     gen
>   selftests: drv-net: rss_ctx: add tests for RSS configuration and
>     contexts

Good suggestion in patch 1 on symbolic errno.

Will leave one minor comment inline.

But overall LGTM, thanks.

Reviewed-by: Willem de Bruijn <willemb@...gle.com>