netdev - Re: [PATCH bpf-next v2 0/4] Fixes for BPF selftests on Loongarch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2319d0d58ccd879ebbc47f368475240bf06870ff.camel@kernel.org>
Date: Tue, 25 Jun 2024 17:08:32 +0800
From: Geliang Tang <geliang@...nel.org>
To: Huacai Chen <chenhuacai@...nel.org>
Cc: John Fastabend <john.fastabend@...il.com>, Jakub Sitnicki
 <jakub@...udflare.com>, "David S. Miller" <davem@...emloft.net>, Eric
 Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo
 Abeni <pabeni@...hat.com>, David Ahern <dsahern@...nel.org>, Andrii
 Nakryiko <andrii@...nel.org>, Eduard Zingerman <eddyz87@...il.com>, Mykola
 Lysenko <mykolal@...com>, Alexei Starovoitov <ast@...nel.org>, Daniel
 Borkmann <daniel@...earbox.net>, Martin KaFai Lau <martin.lau@...ux.dev>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>, KP
 Singh <kpsingh@...nel.org>, Stanislav Fomichev <sdf@...gle.com>, Hao Luo
 <haoluo@...gle.com>, Jiri Olsa <jolsa@...nel.org>, Shuah Khan
 <shuah@...nel.org>,  Mykyta Yatsenko <yatsenko@...a.com>, Miao Xu
 <miaxu@...a.com>, Yuran Pereira <yuran.pereira@...mail.com>, Tiezhu Yang
 <yangtiezhu@...ngson.cn>, Geliang Tang <tanggeliang@...inos.cn>, 
 netdev@...r.kernel.org, bpf@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH bpf-next v2 0/4] Fixes for BPF selftests on Loongarch

On Tue, 2024-06-25 at 16:29 +0800, Huacai Chen wrote:
> On Tue, Jun 25, 2024 at 4:25 PM Geliang Tang <geliang@...nel.org>
> wrote:
> > 
> > From: Geliang Tang <tanggeliang@...inos.cn>
> > 
> > v2:
> >  - add patch 2, a new fix for sk_msg_memcopy_from_iter.
> >  - update patch 3, only test "sk->sk_prot->close" as Eric
> > suggested.
> >  - update patch 4, use "goto err" instead of "return" as Eduard
> >    suggested.
> >  - add "fixes" tag for patch 1-3.
> >  - change subject prefixes as "bpf-next" to trigger BPF CI.
> >  - cc Loongarch maintainers too.
> > 
> > BPF selftests seem to have not been fully tested on Loongarch. When
> > I
> > ran these tests on Loongarch recently, some errors occur. This
> > patch set
> > contains some null-check related fixes for these errors.
> Is the root cause that LoongArch lacks bpf trampoline?

No. These errors don't seem to be directly related to the lack of BPF
trampoline. I have indeed got some errors since lacking BPF trampoline,
which is probably like this:

 test_dctcp:PASS:bpf_dctcp__open_and_load 0 nsec
 test_dctcp:FAIL:bpf_map__attach_struct_ops unexpected error: -524
 #29/1    bpf_tcp_ca/dctcp:FAIL
 test_cubic:PASS:bpf_cubic__open_and_load 0 nsec
 test_cubic:FAIL:bpf_map__attach_struct_ops unexpected error: -524
 #29/2    bpf_tcp_ca/cubic:FAIL
 test_dctcp_fallback:PASS:dctcp_skel 0 nsec
 test_dctcp_fallback:PASS:bpf_dctcp__load 0 nsec
 test_dctcp_fallback:FAIL:dctcp link unexpected error: -524
 #29/4    bpf_tcp_ca/dctcp_fallback:FAIL
 test_write_sk_pacing:PASS:open_and_load 0 nsec
 test_write_sk_pacing:FAIL:attach_struct_ops unexpected error: -524
 #29/6    bpf_tcp_ca/write_sk_pacing:FAIL

Thanks,
-Geliang

> 
> Huacai
> 
> > 
> > Geliang Tang (4):
> >   skmsg: null check for sg_page in sk_msg_recvmsg
> >   skmsg: null check for sg_page in sk_msg_memcopy_from_iter
> >   inet: null check for close in inet_release
> >   selftests/bpf: Null checks for link in bpf_tcp_ca
> > 
> >  net/core/skmsg.c                                 |  4 ++++
> >  net/ipv4/af_inet.c                               |  3 ++-
> >  .../selftests/bpf/prog_tests/bpf_tcp_ca.c        | 16
> > ++++++++++++----
> >  3 files changed, 18 insertions(+), 5 deletions(-)
> > 
> > --
> > 2.43.0
> >