netdev - Re: [net-next PATCH v2 04/15] eth: fbnic: Add register init to set PCIe/Ethernet device config

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <4bf37ab8-2a2f-4692-959c-531519651949@lunn.ch>
Date: Tue, 25 Jun 2024 17:01:34 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Alexander Duyck <alexander.duyck@...il.com>
Cc: netdev@...r.kernel.org, Alexander Duyck <alexanderduyck@...com>,
	kuba@...nel.org, davem@...emloft.net, pabeni@...hat.com
Subject: Re: [net-next PATCH v2 04/15] eth: fbnic: Add register init to set
 PCIe/Ethernet device config

A nitpick:

> +#define CSR_BIT(nr)		(1u << (nr))

Isn't that just

#define CSR_BIT(nr)		BIT(nr)

which makes me wounder why bother? Why not just use BIT()?

	Andrew