netdev - Re: [RFC net-next 00/15] add basic PSP encryption for TCP connections

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240625161707.07642769@kernel.org>
Date: Tue, 25 Jun 2024 16:17:07 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: "Singhai, Anjali" <anjali.singhai@...el.com>
Cc: Willem de Bruijn <willemdebruijn.kernel@...il.com>,
 "netdev@...r.kernel.org" <netdev@...r.kernel.org>, Paolo Abeni
 <pabeni@...hat.com>, Boris Pismenny <borisp@...dia.com>, "gal@...dia.com"
 <gal@...dia.com>, "cratiu@...dia.com" <cratiu@...dia.com>,
 "rrameshbabu@...dia.com" <rrameshbabu@...dia.com>,
 "steffen.klassert@...unet.com" <steffen.klassert@...unet.com>,
 "tariqt@...dia.com" <tariqt@...dia.com>, "Samudrala, Sridhar"
 <sridhar.samudrala@...el.com>, "Acharya, Arun Kumar"
 <arun.kumar.acharya@...el.com>
Subject: Re: [RFC net-next 00/15] add basic PSP encryption for TCP
 connections

On Tue, 25 Jun 2024 22:05:13 +0000 Singhai, Anjali wrote:
> 1. Master key rotation, this needs to be not just from top but also
> from device side because of the master key sharing in some cases and
> a common SPI space that can roll over. So need to have an event
> mechanism from device driver back to kernel for key rotation. Please
> add this.

Sorry I don't need it myself, you'll need to add that once my patches
are merged.

> 2. Header additions in the driver, for now we can do this, but
> ideally it should move to the stack, so that it can be common for all
> devices.

That's fair, I only have mlx5 implementation so I wasn't sure how much
of it is reusable. Once we have 2 drivers we can extrapolate?