netdev - Re: [PATCH net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: 
 <171936422841.4196.14500455106305455588.git-patchwork-notify@kernel.org>
Date: Wed, 26 Jun 2024 01:10:28 +0000
From: patchwork-bot+netdevbpf@...nel.org
To: Neal Cardwell <ncardwell.sw@...il.com>
Cc: davem@...emloft.net, kuba@...nel.org, edumazet@...gle.com,
 netdev@...r.kernel.org, ncardwell@...gle.com, ycheng@...gle.com
Subject: Re: [PATCH net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA_Loss
 for failed TFO

Hello:

This patch was applied to netdev/net.git (main)
by Jakub Kicinski <kuba@...nel.org>:

On Mon, 24 Jun 2024 14:43:23 +0000 you wrote:
> From: Neal Cardwell <ncardwell@...gle.com>
> 
> Testing determined that the recent commit 9e046bb111f1 ("tcp: clear
> tp->retrans_stamp in tcp_rcv_fastopen_synack()") has a race, and does
> not always ensure retrans_stamp is 0 after a TFO payload retransmit.
> 
> If transmit completion for the SYN+data skb happens after the client
> TCP stack receives the SYNACK (which sometimes happens), then
> retrans_stamp can erroneously remain non-zero for the lifetime of the
> connection, causing a premature ETIMEDOUT later.
> 
> [...]

Here is the summary with links:
  - [net] tcp: fix tcp_rcv_fastopen_synack() to enter TCP_CA_Loss for failed TFO
    https://git.kernel.org/netdev/net/c/5dfe9d273932

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html