netdev - Re: [net-next PATCH v2 02/15] eth: fbnic: Add scaffolding for Meta's NIC driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAKgT0Ue0dA394E=2Lg9Y74DQkfEjV==SoxmngHdEGjBX0-qi+A@mail.gmail.com>
Date: Wed, 26 Jun 2024 08:20:35 -0700
From: Alexander Duyck <alexander.duyck@...il.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: netdev@...r.kernel.org, Alexander Duyck <alexanderduyck@...com>, davem@...emloft.net, 
	pabeni@...hat.com
Subject: Re: [net-next PATCH v2 02/15] eth: fbnic: Add scaffolding for Meta's
 NIC driver

On Wed, Jun 26, 2024 at 7:16 AM Jakub Kicinski <kuba@...nel.org> wrote:
>
> On Tue, 25 Jun 2024 07:35:44 -0700 Alexander Duyck wrote:
> > +/**
> > + * fbnic_init_module - Driver Registration Routine
> > + *
> > + * The first routine called when the driver is loaded.  All it does is
> > + * register with the PCI subsystem.
> > + **/
> > +static int __init fbnic_init_module(void)
>
> kdoc got more nit picky in the meantime, we need a Return: annotation
> here.. or maybe make it a non-kdoc comment?

Thanks. I will try to follow up. I see these are reported in the
patchwork so I will make sure to address them before v3 is submitted.

- Alex