lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240626013103.86122-1-kuniyu@amazon.com>
Date: Tue, 25 Jun 2024 18:31:03 -0700
From: Kuniyuki Iwashima <kuniyu@...zon.com>
To: <kuba@...nel.org>
CC: <Rao.Shoaib@...cle.com>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<kuni1840@...il.com>, <kuniyu@...zon.com>, <netdev@...r.kernel.org>,
	<pabeni@...hat.com>
Subject: Re: [PATCH v1 net 00/11] af_unix: Fix bunch of MSG_OOB bugs and add new tests.

From: Jakub Kicinski <kuba@...nel.org>
Date: Tue, 25 Jun 2024 17:43:18 -0700
> On Mon, 24 Jun 2024 18:36:34 -0700 Kuniyuki Iwashima wrote:
> > This series rewrites the selftest for AF_UNIX MSG_OOB and fixes
> > bunch of bugs that AF_UNIX behaves differently compared to TCP.
> 
> I like pairing the fix with the selftest, but at the same time
> "let's rewrite the selftest first" gives me pause. We have 40 LoC
> of actual changes here and 1000 LoC of test churn.
> 
> I guess we'll find out on Thursday if we went too far :)

I hope it's worth for finding 4 AF_UNIX bugs and 2 ancient TCP ones,
let's see 🤞


> 
> >  net/unix/af_unix.c                            |  37 +-
> >  tools/testing/selftests/net/.gitignore        |   1 -
> >  tools/testing/selftests/net/af_unix/Makefile  |   2 +-
> >  tools/testing/selftests/net/af_unix/msg_oob.c | 734 ++++++++++++++++++
> >  .../selftests/net/af_unix/test_unix_oob.c     | 436 -----------
> >  5 files changed, 766 insertions(+), 444 deletions(-)
> >  create mode 100644 tools/testing/selftests/net/af_unix/msg_oob.c
> >  delete mode 100644 tools/testing/selftests/net/af_unix/test_unix_oob.c

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ