netdev - Re: [PATCH net] tcp_metrics: validate source addr length

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 26 Jun 2024 23:00:54 +0200
From: Eric Dumazet <edumazet@...gle.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: davem@...emloft.net, netdev@...r.kernel.org, pabeni@...hat.com, 
	dsahern@...nel.org, christoph.paasch@...ouvain.be
Subject: Re: [PATCH net] tcp_metrics: validate source addr length

On Wed, Jun 26, 2024 at 9:47 PM Jakub Kicinski <kuba@...nel.org> wrote:
>
> I don't see anything checking that TCP_METRICS_ATTR_SADDR_IPV4
> is at least 4 bytes long, and the policy doesn't have an entry
> for this attribute at all (neither does it for IPv6 but v6 is
> manually validated).
>
> Fixes: 8a59359cb80f ("tcp: metrics: New netlink attribute for src IP and dumped in netlink reply")

This  commit added dump only for these attributes.

It seems the bug was added in

commit 3e7013ddf55af7bc191792b8aea0c2b94fb0fef5
Author: Christoph Paasch <christoph.paasch@...ouvain.be>
Date:   Wed Jan 8 16:05:59 2014 +0100

    tcp: metrics: Allow selective get/del of tcp-metrics based on src IP


> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> In net-next we can make v6 use policy for validation, too.
> But it will conflict, so I'll send that on Thu.


Reviewed-by: Eric Dumazet <edumazet@...gle.com>