[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240626081215.2824627-1-make24@iscas.ac.cn>
Date: Wed, 26 Jun 2024 16:12:15 +0800
From: Ma Ke <make24@...as.ac.cn>
To: wintera@...ux.ibm.com,
twinkler@...ux.ibm.com,
hca@...ux.ibm.com,
gor@...ux.ibm.com,
agordeev@...ux.ibm.com,
borntraeger@...ux.ibm.com,
svens@...ux.ibm.com,
davem@...emloft.net,
ubraun@...ux.ibm.com,
sebott@...ux.ibm.com
Cc: linux-s390@...r.kernel.org,
netdev@...r.kernel.org,
linux-kernel@...r.kernel.org,
Ma Ke <make24@...as.ac.cn>
Subject: [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism_probe()
As the possible failure of the dma_set_max_seg_size(), we should better
check the return value of the dma_set_max_seg_size().
Fixes: 684b89bc39ce ("s390/ism: add device driver for internal shared memory")
Signed-off-by: Ma Ke <make24@...as.ac.cn>
---
drivers/s390/net/ism_drv.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/s390/net/ism_drv.c b/drivers/s390/net/ism_drv.c
index e36e3ea165d3..9ddd093a0368 100644
--- a/drivers/s390/net/ism_drv.c
+++ b/drivers/s390/net/ism_drv.c
@@ -620,7 +620,9 @@ static int ism_probe(struct pci_dev *pdev, const struct pci_device_id *id)
goto err_resource;
dma_set_seg_boundary(&pdev->dev, SZ_1M - 1);
- dma_set_max_seg_size(&pdev->dev, SZ_1M);
+ ret = dma_set_max_seg_size(&pdev->dev, SZ_1M);
+ if (ret)
+ return ret;
pci_set_master(pdev);
ret = ism_dev_init(ism);
--
2.25.1
Powered by blists - more mailing lists