netdev - Re: [PATCH net-next v3] enic: add ethtool get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240626191014.25b9b352@kernel.org>
Date: Wed, 26 Jun 2024 19:10:14 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Jon Kohler <jon@...anix.com>
Cc: Christian Benvenuti <benve@...co.com>, Satish Kharat
 <satishkh@...co.com>, "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v3] enic: add ethtool get_channel support

On Tue, 25 Jun 2024 17:53:38 -0700 Jon Kohler wrote:
> +		channels->combined_count = 1;

clang complains about the lack of break or fallthrough here,
as annoying and pointless of a warning as it is :(

drivers/net/ethernet/cisco/enic/enic_ethtool.c:627:2: note: insert 'break;' to avoid fall-through
  627 |         default:
      |         ^
      |         break; 

> +	default:
> +		break;
-- 
pw-bot: cr