netdev - Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240627082736.34ded856@hermes.local>
Date: Thu, 27 Jun 2024 08:27:36 -0700
From: Stephen Hemminger <stephen@...workplumber.org>
To: Konstantin Taranov <kotaranov@...rosoft.com>
Cc: Leon Romanovsky <leon@...nel.org>, Haiyang Zhang
 <haiyangz@...rosoft.com>, Konstantin Taranov
 <kotaranov@...ux.microsoft.com>, Wei Hu <weh@...rosoft.com>,
 "sharmaajay@...rosoft.com" <sharmaajay@...rosoft.com>, Long Li
 <longli@...rosoft.com>, "jgg@...pe.ca" <jgg@...pe.ca>,
 "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>, linux-netdev
 <netdev@...r.kernel.org>
Subject: Re: [PATCH rdma-next 1/1] RDMA/mana_ib: Set correct device into ib

On Thu, 27 Jun 2024 10:44:02 +0000
Konstantin Taranov <kotaranov@...rosoft.com> wrote:

> > 
> > I don't want to be first and only one driver that uses this flag outside of
> > netdev. So please add new function to netdev part of mana driver to return
> > right ndev.
> > 
> > Something like that:
> > struct net_device *mana__get_netdev(struct mana_context *mc) {
> > 	struct net_device *ndev;
> > 
> > 	if (mana_ndev_is_slave(mc->ports[0]))
> > 		ndev = netdev_master_upper_dev_get_rcu(mc->ports[0]);
> > 	else
> > 		ndev = mc->ports[0];
> > 
> > 	return ndev;
> > }
> > 
> > And get Acks from netdev maintainers (Jakub, David, Eric, Paolo).  
> 
> Ok. Makes sense.
> I will just call it more exact:
> mana_get_not_slave_netdev_rcu()

Please don't introduce more usages of the term "slave".
Better to stick to VF.