netdev - Re: [PATCH net-next 10/10] bnxt_en: Remove atomic operations on ptp->tx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CALs4sv2YsfZrqqXxbw47EkBsRJnr90B8sQkNz3Wm3J=zaWK5xg@mail.gmail.com>
Date: Thu, 27 Jun 2024 21:04:27 +0530
From: Pavan Chebbi <pavan.chebbi@...adcom.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: Michael Chan <michael.chan@...adcom.com>, netdev@...r.kernel.org, edumazet@...gle.com, 
	kuba@...nel.org, pabeni@...hat.com, andrew.gospodarek@...adcom.com, 
	richardcochran@...il.com, davem@...emloft.net
Subject: Re: [PATCH net-next 10/10] bnxt_en: Remove atomic operations on ptp->tx_avail

On Thu, Jun 27, 2024 at 3:10 PM Przemek Kitszel
<przemyslaw.kitszel@...el.com> wrote:
>
> On 6/26/24 18:43, Michael Chan wrote:
> > From: Pavan Chebbi <pavan.chebbi@...adcom.com>
> >
> > Now that we require the spinlock to protect ptp->txts_prod, change
> > ptp->tx_avail to non-atomic and protect it under the same spinlock.
>
> Under what condition you will exceed those 4 entries?

Only when an application chooses to do so.

>
> > Add a new helper function bnxt_ptp_get_txts_prod() to decrement
> > ptp->tx_avail under spinlock and return the producer.
> >
> > Signed-off-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
>
> overall it is a good series, thanks!

Thanks for the review, Przemek!

>
> > ---
> >   drivers/net/ethernet/broadcom/bnxt/bnxt.c     | 20 +++-------------
> >   drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.c | 23 +++++++++++++++----
> >   drivers/net/ethernet/broadcom/bnxt/bnxt_ptp.h | 10 +++++++-
> >   3 files changed, 31 insertions(+), 22 deletions(-)
> >
>

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)