netdev - Re: [PATCH net-next 01/10] bnxt_en: Add new TX timestamp completion definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 08:54:46 -0700
From: Michael Chan <michael.chan@...adcom.com>
To: Przemek Kitszel <przemyslaw.kitszel@...el.com>
Cc: netdev@...r.kernel.org, edumazet@...gle.com, kuba@...nel.org, 
	pabeni@...hat.com, pavan.chebbi@...adcom.com, andrew.gospodarek@...adcom.com, 
	richardcochran@...il.com, davem@...emloft.net
Subject: Re: [PATCH net-next 01/10] bnxt_en: Add new TX timestamp completion definitions

On Thu, Jun 27, 2024 at 2:00 AM Przemek Kitszel
<przemyslaw.kitszel@...el.com> wrote:
>
> On 6/26/24 18:42, Michael Chan wrote:
> > The new BCM5760X chips will generate this new TX timestamp completion
> > when a TX packet's timestamp has been taken right before transmission.
>
> Tx
>
> > The driver logic to retreive the timestamp will be added in the next
>
> retrieve
>
> > few patches.
> >
> > Reviewed-by: Pavan Chebbi <pavan.chebbi@...adcom.com>
> > Reviewed-by: Andy Gospodarek <andrew.gospodarek@...adcom.com>
> > Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> > ---
> >   drivers/net/ethernet/broadcom/bnxt/bnxt.h | 26 +++++++++++++++++++++++
> >   1 file changed, 26 insertions(+)
> >
> > diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt.h b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > index 9cf0acfa04e5..d3ad73d4c00a 100644
> > --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.h
> > @@ -181,6 +181,32 @@ struct tx_cmp {
> >   #define TX_CMP_SQ_CONS_IDX(txcmp)                                   \
> >       (le32_to_cpu((txcmp)->sq_cons_idx) & TX_CMP_SQ_CONS_IDX_MASK)
> >
> > +struct tx_ts_cmp {
> > +     __le32 tx_ts_cmp_flags_type;
> > +     #define TX_TS_CMP_FLAGS_ERROR                           (1 << 6)
>
> those should be BIT(6)
>
> > +     #define TX_TS_CMP_FLAGS_TS_TYPE                         (1 << 7)
> > +      #define TX_TS_CMP_FLAGS_TS_TYPE_PM                      (0 << 7)
>
> weird way to spell 0

These hardware interface structures are generated internally from
yaml.  All similar structures in this .h file have the same format.  I
think it will be better to convert them all together in the future to
keep everything consistent.

Download attachment "smime.p7s" of type "application/pkcs7-signature" (4209 bytes)