netdev - Re: [PATCH] net: phy: phy_device: Fix PHY LED blinking code comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <36f46cea-0811-47dc-8741-042d9b88df88@denx.de>
Date: Wed, 26 Jun 2024 21:47:38 +0200
From: Marek Vasut <marex@...x.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: netdev@...r.kernel.org, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, kernel@...electronics.com,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] net: phy: phy_device: Fix PHY LED blinking code comment

On 6/26/24 7:32 PM, Andrew Lunn wrote:
> On Wed, Jun 26, 2024 at 05:06:17AM +0200, Marek Vasut wrote:
>> Fix copy-paste error in the code comment. The code refers to
>> LED blinking configuration, not brightness configuration. It
>> was likely copied from comment above this one which does
>> refer to brightness configuration.
>>
>> Fixes: 4e901018432e ("net: phy: phy_device: Call into the PHY driver to set LED blinking")
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> 
> There is a lot of context in this patch. Do you have some odd git diff
> settings?

I did use git format-patch -U10 this time, to make sure that context is 
visible. With regular git format-patch, the diff contained only part of 
the comment and it wasn't clear from the diff that it does modify 
comment above (*led_blink_set)() and not e.g. (*led_brightness_set)() .