netdev - Re: [PATCH net-next] dt-bindings: net: Define properties at top-level

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 13:03:01 -0600
From: Rob Herring <robh@...nel.org>
To: Serge Semin <fancer.lancer@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, 
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, 
	Lorenzo Bianconi <lorenzo@...nel.org>, Felix Fietkau <nbd@....name>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Giuseppe Cavallaro <peppe.cavallaro@...com>, 
	Jose Abreu <joabreu@...opsys.com>, netdev@...r.kernel.org, devicetree@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-mediatek@...ts.infradead.org
Subject: Re: [PATCH net-next] dt-bindings: net: Define properties at top-level

On Wed, Jun 26, 2024 at 9:05 AM Serge Semin <fancer.lancer@...il.com> wrote:
>
> Hi Rob
>
> On Tue, Jun 25, 2024 at 03:54:41PM -0600, Rob Herring (Arm) wrote:
> > Convention is DT schemas should define all properties at the top-level
> > and not inside of if/then schemas. That minimizes the if/then schemas
> > and is more future proof.
> >
> > Signed-off-by: Rob Herring (Arm) <robh@...nel.org>
> > ---
> >  .../devicetree/bindings/net/mediatek,net.yaml |  28 +--
>
> >  .../devicetree/bindings/net/snps,dwmac.yaml   | 167 +++++++++---------
>
> For Synopsys DW MACs you can just move the PBL-properties constraints to
> the top-level schema part with no compatible-based conditional
> validation left. It's because the DMA PBL settings are available on all the
> DW MAC IP-cores (DW MAC, DW GMAC, DW QoS Eth, DW XGMAC, DW XLGMAC).
> Moreover the STMMAC driver responsible for the DW MAC device handling
> parses the pbl* properties for all IP-cores irrespective from the
> device compatible string.

That's definitely better. Will still need the TSO flag part though,
really, who cares if someone wants to set that on h/w without TSO...

>
> Alternatively you can just merge in the attached patch, which BTW you
> have already reviewed sometime ago.

Can you send that to the list since it changed from the last version.

Rob