netdev - Re: [PATCH] net/dcb: check for detached device before executing callbacks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Thu, 27 Jun 2024 10:26:41 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Denis Kirjanov <kirjanov@...il.com>, netdev@...r.kernel.org
Cc: Denis Kirjanov <dkirjanov@...e.de>, Hannes Reinecke <hare@...e.de>
Subject: Re: [PATCH] net/dcb: check for detached device before executing
 callbacks

Hi,

On Mon, 2024-06-24 at 09:46 -0400, Denis Kirjanov wrote:
> When a netdevice is detached there is no point in trying to execute
> the dcb callbacks; at best they will return stale information, and
> at worst crash the machine.
> 
> Fixes: 2f90b8657ec94 ("ixgbe: this patch adds support for DCB to the kernel and ixgbe driver")
> Signed-off-by: Hannes Reinecke <hare@...e.de>
> Signed-off-by: Denis Kirjanov <dkirjanov@...e.de>

The patch LGTM, but please fix the patch sender to match the patch
author to make checkpatch happy.

./scripts/checkpatch.pl --strict  --git HEAD^..

before the submission is your friend:)

Also please add the target tree ('net') in the subj prefix when you
will submit the next revision.

Thanks!

Paolo