netdev - Re: [devel-ipsec] [PATCH ipsec-next, v4] xfrm: support sending NAT keepalives in ESP in UDP states

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zn04lL533UFXpvYZ@gauss3.secunet.de>
Date: Thu, 27 Jun 2024 12:01:56 +0200
From: Steffen Klassert <steffen.klassert@...unet.com>
To: Antony Antony <antony.antony@...unet.com>
CC: Eyal Birger <eyal.birger@...il.com>, <davem@...emloft.net>,
	<dsahern@...nel.org>, <edumazet@...gle.com>, <kuba@...nel.org>,
	<pabeni@...hat.com>, <herbert@...dor.apana.org.au>, <pablo@...filter.org>,
	<paul.wouters@...en.io>, <nharold@...gle.com>, <mcr@...delman.ca>,
	<devel@...ux-ipsec.org>, <netdev@...r.kernel.org>
Subject: Re: [devel-ipsec] [PATCH ipsec-next, v4] xfrm: support sending NAT
 keepalives in ESP in UDP states

On Tue, Jun 25, 2024 at 12:21:28PM +0200, Antony Antony wrote:
> On Mon, May 27, 2024 at 20:29:14 -0700, Eyal Birger via Devel wrote:
> > Add the ability to send out RFC-3948 NAT keepalives from the xfrm stack.
> > 
> > To use, Userspace sets an XFRM_NAT_KEEPALIVE_INTERVAL integer property when
> > creating XFRM outbound states which denotes the number of seconds between
> > keepalive messages.
> > 
> > Keepalive messages are sent from a per net delayed work which iterates over
> > the xfrm states. The logic is guarded by the xfrm state spinlock due to the
> > xfrm state walk iterator.
> > 
> > Possible future enhancements:
> > 
> > - Adding counters to keep track of sent keepalives.
> > - deduplicate NAT keepalives between states sharing the same nat keepalive
> >   parameters.
> > - provisioning hardware offloads for devices capable of implementing this.
> > - revise xfrm state list to use an rcu list in order to avoid running this
> >   under spinlock.
> > 
> > Suggested-by: Paul Wouters <paul.wouters@...en.io>
> > Signed-off-by: Eyal Birger <eyal.birger@...il.com>
> 
> Tested-by: Antony Antony <antony.antony@...unet.com>

Now applied to ipsec-next, thanks everyone!