netdev - Re: IP oversized ip oacket from - header size should be skipped?

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240628105343.GA14296@breakpoint.cc>
Date: Fri, 28 Jun 2024 12:53:43 +0200
From: Florian Westphal <fw@...len.de>
To: Ian Kumlien <ian.kumlien@...il.com>
Cc: Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: IP oversized ip oacket from - header size should be skipped?

Ian Kumlien <ian.kumlien@...il.com> wrote:
> Hi,
> 
> In net/ipv4/ip_fragment.c line 412:
> static int ip_frag_reasm(struct ipq *qp, struct sk_buff *skb,
>                          struct sk_buff *prev_tail, struct net_device *dev)
> {
> ...
>         len = ip_hdrlen(skb) + qp->q.len;
>         err = -E2BIG;
>         if (len > 65535)
>                 goto out_oversize;
> ....
> 
> We can expand the expression to:
> len = (ip_hdr(skb)->ihl * 4) + qp->q.len;
> 
> But it's still weird since the definition of q->len is: "total length
> of the original datagram"

AFAICS datagram == l4 payload, so adding ihl is correct.