netdev - Re: [PATCH net-next 4/5] io_uring/net: move charging socket out of zc io

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <667eedae8096e_2185b2948@willemb.c.googlers.com.notmuch>
Date: Fri, 28 Jun 2024 13:06:54 -0400
From: Willem de Bruijn <willemdebruijn.kernel@...il.com>
To: Pavel Begunkov <asml.silence@...il.com>, 
 io-uring@...r.kernel.org, 
 netdev@...r.kernel.org
Cc: Jens Axboe <axboe@...nel.dk>, 
 asml.silence@...il.com, 
 "David S . Miller" <davem@...emloft.net>, 
 Jakub Kicinski <kuba@...nel.org>, 
 David Ahern <dsahern@...nel.org>, 
 Eric Dumazet <edumazet@...gle.com>, 
 Willem de Bruijn <willemdebruijn.kernel@...il.com>
Subject: Re: [PATCH net-next 4/5] io_uring/net: move charging socket out of zc
 io_uring

Pavel Begunkov wrote:
> Currently, io_uring's io_sg_from_iter() duplicates the part of
> __zerocopy_sg_from_iter() charging pages to the socket. It'd be too easy
> to miss while changing it in net/, the chunk is not the most
> straightforward for outside users and full of internal implementation
> details. io_uring is not a good place to keep it, deduplicate it by
> moving out of the callback into __zerocopy_sg_from_iter().
> 
> Signed-off-by: Pavel Begunkov <asml.silence@...il.com>

Reviewed-by: Willem de Bruijn <willemb@...gle.com>