[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202406281051.NAiS477l-lkp@intel.com>
Date: Fri, 28 Jun 2024 11:11:42 +0800
From: kernel test robot <lkp@...el.com>
To: zijianzhang@...edance.com, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, edumazet@...gle.com,
willemdebruijn.kernel@...il.com, cong.wang@...edance.com,
xiaochun.lu@...edance.com, Zijian Zhang <zijianzhang@...edance.com>
Subject: Re: [PATCH net-next v6 2/4] sock: support copy cmsg to userspace in
TX path
Hi,
kernel test robot noticed the following build warnings:
[auto build test WARNING on net-next/main]
url: https://github.com/intel-lab-lkp/linux/commits/zijianzhang-bytedance-com/selftests-fix-OOM-problem-in-msg_zerocopy-selftest/20240627-150801
base: net-next/main
patch link: https://lore.kernel.org/r/20240626193403.3854451-3-zijianzhang%40bytedance.com
patch subject: [PATCH net-next v6 2/4] sock: support copy cmsg to userspace in TX path
config: i386-randconfig-062-20240628 (https://download.01.org/0day-ci/archive/20240628/202406281051.NAiS477l-lkp@intel.com/config)
compiler: gcc-13 (Ubuntu 13.2.0-4ubuntu3) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240628/202406281051.NAiS477l-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202406281051.NAiS477l-lkp@intel.com/
sparse warnings: (new ones prefixed by >>)
>> net/socket.c:2635:30: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *msg_control @@ got void [noderef] __user *[noderef] __user msg_control @@
net/socket.c:2635:30: sparse: expected void *msg_control
net/socket.c:2635:30: sparse: got void [noderef] __user *[noderef] __user msg_control
>> net/socket.c:2629:49: sparse: sparse: dereference of noderef expression
vim +2635 net/socket.c
2623
2624 static int sendmsg_copy_cmsg_to_user(struct msghdr *msg_sys,
2625 struct user_msghdr __user *umsg)
2626 {
2627 struct compat_msghdr __user *umsg_compat =
2628 (struct compat_msghdr __user *)umsg;
> 2629 unsigned long cmsg_ptr = (unsigned long)umsg->msg_control;
2630 unsigned int flags = msg_sys->msg_flags;
2631 struct msghdr msg_user = *msg_sys;
2632 struct cmsghdr *cmsg;
2633 int err;
2634
> 2635 msg_user.msg_control = umsg->msg_control;
2636 msg_user.msg_control_is_user = true;
2637 for_each_cmsghdr(cmsg, msg_sys) {
2638 if (!CMSG_OK(msg_sys, cmsg))
2639 break;
2640 if (cmsg_copy_to_user(cmsg))
2641 put_cmsg(&msg_user, cmsg->cmsg_level, cmsg->cmsg_type,
2642 cmsg->cmsg_len - sizeof(*cmsg), CMSG_DATA(cmsg));
2643 }
2644
2645 err = __put_user((msg_sys->msg_flags & ~MSG_CMSG_COMPAT), COMPAT_FLAGS(umsg));
2646 if (err)
2647 return err;
2648 if (MSG_CMSG_COMPAT & flags)
2649 err = __put_user((unsigned long)msg_user.msg_control - cmsg_ptr,
2650 &umsg_compat->msg_controllen);
2651 else
2652 err = __put_user((unsigned long)msg_user.msg_control - cmsg_ptr,
2653 &umsg->msg_controllen);
2654 return err;
2655 }
2656
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists