netdev - Re: [PATCH] s390/ism: Add check for dma_set_max_seg_size in ism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Zn5POphJ8pckZ3hY@infradead.org>
Date: Thu, 27 Jun 2024 22:50:50 -0700
From: Christoph Hellwig <hch@...radead.org>
To: Gerd Bayer <gbayer@...ux.ibm.com>
Cc: Ma Ke <make24@...as.ac.cn>, wintera@...ux.ibm.com,
	twinkler@...ux.ibm.com, Niklas Schnelle <schnelle@...ux.ibm.com>,
	Wenjia Zhang <wenjia@...ux.ibm.com>, linux-s390@...r.kernel.org,
	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	hca@...ux.ibm.com, gor@...ux.ibm.com, agordeev@...ux.ibm.com,
	borntraeger@...ux.ibm.com, svens@...ux.ibm.com, davem@...emloft.net,
	Stefan Raspl <raspl@...ux.ibm.com>
Subject: Re: [PATCH] s390/ism: Add check for dma_set_max_seg_size in
 ism_probe()

On Wed, Jun 26, 2024 at 02:48:30PM +0200, Gerd Bayer wrote:
> 
> However, since ISM devices are PCI attached (and will remain PCI
> attached I believe) we can take the existance of dev->dma_parms for
> granted since pci_device_add() (in drivers/pci/probe.c) will make that
> point to the pci_dev's dma_parms for every PCI device.
> 
> So I'm not sure how important this fix is.

It's not just important, it is stupid and I told them to stop sending
these kinds of crap patches.