lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202407012054.beATJPnF-lkp@intel.com>
Date: Mon, 1 Jul 2024 21:48:06 +0800
From: kernel test robot <lkp@...el.com>
To: Jacobe Zang <jacobe.zang@...ion.com>, robh@...nel.org,
	krzk+dt@...nel.org, heiko@...ech.de, kvalo@...nel.org,
	davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, conor+dt@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, efectn@...tonmail.com,
	dsimic@...jaro.org, jagan@...eble.ai, devicetree@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	linux-rockchip@...ts.infradead.org, linux-kernel@...r.kernel.org,
	arend@...adcom.com, linux-wireless@...r.kernel.org,
	netdev@...r.kernel.org, megi@....cz, duoming@....edu.cn,
	bhelgaas@...gle.com, minipli@...ecurity.net,
	brcm80211@...ts.linux.dev, brcm80211-dev-list.pdl@...adcom.com,
	nick@...das.com, Jacobe Zang <jacobe.zang@...ion.com>
Subject: Re: [PATCH v3 4/5] wifi: brcmfmac: Add optional lpo clock enable
 support

Hi Jacobe,

kernel test robot noticed the following build warnings:

[auto build test WARNING on wireless-next/main]
[also build test WARNING on wireless/main rockchip/for-next robh/for-next linus/master v6.10-rc6 next-20240701]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Jacobe-Zang/dt-bindings-net-wireless-brcm4329-fmac-add-pci14e4-449d/20240630-221025
base:   https://git.kernel.org/pub/scm/linux/kernel/git/wireless/wireless-next.git main
patch link:    https://lore.kernel.org/r/20240630073605.2164346-5-jacobe.zang%40wesion.com
patch subject: [PATCH v3 4/5] wifi: brcmfmac: Add optional lpo clock enable support
config: sparc-allmodconfig
compiler: sparc64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build):

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407012054.beATJPnF-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:37:
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c: In function 'brcmf_pcie_probe':
>> drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c:2426:33: warning: too many arguments for format [-Wformat-extra-args]
    2426 |                 brcmf_dbg(PCIE, "enabling 32kHz clock\n", pdev->vendor, pdev->device);
         |                                 ^~~~~~~~~~~~~~~~~~~~~~~~
   drivers/net/wireless/broadcom/brcm80211/brcmfmac/debug.h:77:21: note: in definition of macro 'brcmf_dbg'
      77 |                     fmt, ##__VA_ARGS__);                        \
         |                     ^~~


vim +2426 drivers/net/wireless/broadcom/brcm80211/brcmfmac/pcie.c

  2400	
  2401	static int
  2402	brcmf_pcie_probe(struct pci_dev *pdev, const struct pci_device_id *id)
  2403	{
  2404		int ret;
  2405		struct brcmf_fw_request *fwreq;
  2406		struct brcmf_pciedev_info *devinfo;
  2407		struct brcmf_pciedev *pcie_bus_dev;
  2408		struct brcmf_core *core;
  2409		struct brcmf_bus *bus;
  2410		struct clk *clk;
  2411	
  2412		if (!id) {
  2413			id = pci_match_id(brcmf_pcie_devid_table, pdev);
  2414			if (!id) {
  2415				pci_err(pdev, "Error could not find pci_device_id for %x:%x\n", pdev->vendor, pdev->device);
  2416				return -ENODEV;
  2417			}
  2418		}
  2419	
  2420		brcmf_dbg(PCIE, "Enter %x:%x\n", pdev->vendor, pdev->device);
  2421	
  2422		clk = devm_clk_get_optional_enabled(&pdev->dev, "lpo");
  2423		if (IS_ERR(clk))
  2424			return PTR_ERR(clk);
  2425		if (clk) {
> 2426			brcmf_dbg(PCIE, "enabling 32kHz clock\n", pdev->vendor, pdev->device);
  2427			clk_set_rate(clk, 32768);
  2428		}
  2429	
  2430		ret = -ENOMEM;
  2431		devinfo = kzalloc(sizeof(*devinfo), GFP_KERNEL);
  2432		if (devinfo == NULL)
  2433			return ret;
  2434	
  2435		devinfo->pdev = pdev;
  2436		pcie_bus_dev = NULL;
  2437		devinfo->ci = brcmf_chip_attach(devinfo, pdev->device,
  2438						&brcmf_pcie_buscore_ops);
  2439		if (IS_ERR(devinfo->ci)) {
  2440			ret = PTR_ERR(devinfo->ci);
  2441			devinfo->ci = NULL;
  2442			goto fail;
  2443		}
  2444	
  2445		core = brcmf_chip_get_core(devinfo->ci, BCMA_CORE_PCIE2);
  2446		if (core->rev >= 64)
  2447			devinfo->reginfo = &brcmf_reginfo_64;
  2448		else
  2449			devinfo->reginfo = &brcmf_reginfo_default;
  2450	
  2451		pcie_bus_dev = kzalloc(sizeof(*pcie_bus_dev), GFP_KERNEL);
  2452		if (pcie_bus_dev == NULL) {
  2453			ret = -ENOMEM;
  2454			goto fail;
  2455		}
  2456	
  2457		devinfo->settings = brcmf_get_module_param(&devinfo->pdev->dev,
  2458							   BRCMF_BUSTYPE_PCIE,
  2459							   devinfo->ci->chip,
  2460							   devinfo->ci->chiprev);
  2461		if (!devinfo->settings) {
  2462			ret = -ENOMEM;
  2463			goto fail;
  2464		}
  2465	
  2466		bus = kzalloc(sizeof(*bus), GFP_KERNEL);
  2467		if (!bus) {
  2468			ret = -ENOMEM;
  2469			goto fail;
  2470		}
  2471		bus->msgbuf = kzalloc(sizeof(*bus->msgbuf), GFP_KERNEL);
  2472		if (!bus->msgbuf) {
  2473			ret = -ENOMEM;
  2474			kfree(bus);
  2475			goto fail;
  2476		}
  2477	
  2478		/* hook it all together. */
  2479		pcie_bus_dev->devinfo = devinfo;
  2480		pcie_bus_dev->bus = bus;
  2481		bus->dev = &pdev->dev;
  2482		bus->bus_priv.pcie = pcie_bus_dev;
  2483		bus->ops = &brcmf_pcie_bus_ops;
  2484		bus->proto_type = BRCMF_PROTO_MSGBUF;
  2485		bus->fwvid = id->driver_data;
  2486		bus->chip = devinfo->coreid;
  2487		bus->wowl_supported = pci_pme_capable(pdev, PCI_D3hot);
  2488		dev_set_drvdata(&pdev->dev, bus);
  2489	
  2490		ret = brcmf_alloc(&devinfo->pdev->dev, devinfo->settings);
  2491		if (ret)
  2492			goto fail_bus;
  2493	
  2494		ret = brcmf_pcie_read_otp(devinfo);
  2495		if (ret) {
  2496			brcmf_err(bus, "failed to parse OTP\n");
  2497			goto fail_brcmf;
  2498		}
  2499	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

View attachment "reproduce" of type "text/plain" (808 bytes)

View attachment "config" of type "text/plain" (339736 bytes)

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ