netdev - Re: [PATCH iwl-next 7/7] ice: Enable 1PPS out from CGU for E825C products

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <815f7f5c-6d98-4be2-8fc7-09851fe281d0@intel.com>
Date: Mon, 1 Jul 2024 17:08:09 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Simon Horman <horms@...nel.org>, Karol Kolacinski
	<karol.kolacinski@...el.com>
CC: <intel-wired-lan@...ts.osuosl.org>, <netdev@...r.kernel.org>,
	<anthony.l.nguyen@...el.com>, Sergey Temerkhanov
	<sergey.temerkhanov@...el.com>, Arkadiusz Kubalewski
	<arkadiusz.kubalewski@...el.com>
Subject: Re: [PATCH iwl-next 7/7] ice: Enable 1PPS out from CGU for E825C
 products

On 7/1/24 15:27, Simon Horman wrote:
> On Thu, Jun 27, 2024 at 05:09:31PM +0200, Karol Kolacinski wrote:
>> From: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
>>
>> Implement 1PPS signal enabling/disabling in CGU. The amplitude is
>> always the maximum in this implementation
>>
>> Reviewed-by: Arkadiusz Kubalewski <arkadiusz.kubalewski@...el.com>
>> Signed-off-by: Sergey Temerkhanov <sergey.temerkhanov@...el.com>
>> Co-developed-by: Karol Kolacinski <karol.kolacinski@...el.com>
>> Signed-off-by: Karol Kolacinski <karol.kolacinski@...el.com>
> 
> ...
> 
>> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
>> index 07ecf2a86742..fa7cf8453b88 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
>> +++ b/drivers/net/ethernet/intel/ice/ice_ptp_hw.c
>> @@ -661,6 +661,27 @@ static int ice_cfg_cgu_pll_e825c(struct ice_hw *hw,
>>   	return 0;
>>   }
>>   
>> +#define ICE_ONE_PPS_OUT_AMP_MAX 3
>> +
>> +/**
>> + * ice_cgu_ena_pps_out - Enable/disable 1PPS output
>> + * @hw: pointer to the HW struct
>> + * @ena: Enable/disable 1PPS output
> 
> Please include a "Returns: " or "Return: " section in the kernel doc
> for functions that have a return value.

last time I have checked only the singular "Return:" was supported (aka
non-complained) by kdoc checker on W=2 builds

> 
> NIPA has recently got more picky about this.
> Flagged by kernel-doc -none --Warn
> 
>> + */
>> +int ice_cgu_ena_pps_out(struct ice_hw *hw, bool ena)
>> +{
>> +	union nac_cgu_dword9 dw9;
>> +	int err;
>> +
>> +	err = ice_read_cgu_reg_e82x(hw, NAC_CGU_DWORD9, &dw9.val);
>> +	if (err)
>> +		return err;
>> +
>> +	dw9.one_pps_out_en = ena;
>> +	dw9.one_pps_out_amp = ena * ICE_ONE_PPS_OUT_AMP_MAX;
>> +	return ice_write_cgu_reg_e82x(hw, NAC_CGU_DWORD9, dw9.val);
>> +}
>> +
>>   /**
>>    * ice_cfg_cgu_pll_dis_sticky_bits_e82x - disable TS PLL sticky bits
>>    * @hw: pointer to the HW struct
> 
> ...
>