netdev - Re: [PATCH RESEND bpf-next v4 2/3] selftests/bpf: Factor out many args tests from tracing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2bbced4a-1022-aace-52b4-e0abe426347b@iogearbox.net>
Date: Mon, 1 Jul 2024 18:12:31 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Pu Lehui <pulehui@...weicloud.com>, bpf@...r.kernel.org,
 linux-riscv@...ts.infradead.org, netdev@...r.kernel.org
Cc: Björn Töpel <bjorn@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Eduard Zingerman
 <eddyz87@...il.com>, Song Liu <song@...nel.org>, Yonghong Song <yhs@...com>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Puranjay Mohan <puranjay@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>, Pu Lehui <pulehui@...wei.com>
Subject: Re: [PATCH RESEND bpf-next v4 2/3] selftests/bpf: Factor out many
 args tests from tracing_struct

On 6/22/24 4:21 AM, Pu Lehui wrote:
> From: Pu Lehui <pulehui@...wei.com>
> 
> Factor out many args tests from tracing_struct and rename some function
> names to make more sense.
> 
> Signed-off-by: Pu Lehui <pulehui@...wei.com>
[...]
> diff --git a/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c b/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c
> new file mode 100644
> index 000000000000..8bd696dc81d9
> --- /dev/null
> +++ b/tools/testing/selftests/bpf/progs/tracing_struct_many_args.c
> @@ -0,0 +1,62 @@
> +// SPDX-License-Identifier: GPL-2.0
> +/* Copyright (C) 2024. Huawei Technologies Co., Ltd */

Overall looks good and ready to land, one small request: lets drop the copyright
comment here since this commit is only moving the existing tests out to its own
file which have been added originally via 5e9cf77d81f9 ("selftests/bpf: add testcase
for TRACING with 6+ arguments").

Thanks,
Daniel