netdev - Re: [net-next,PATCH v2] dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as compatible strings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 1 Jul 2024 20:35:37 +0200
From: Marek Vasut <marex@...x.de>
To: Geert Uytterhoeven <geert@...ux-m68k.org>
Cc: netdev@...r.kernel.org, Andrew Lunn <andrew@...n.ch>,
 Conor Dooley <conor+dt@...nel.org>, "David S . Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Florian Fainelli <f.fainelli@...il.com>,
 Heiner Kallweit <hkallweit1@...il.com>, Jakub Kicinski <kuba@...nel.org>,
 Joakim Zhang <qiangqing.zhang@....com>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Rob Herring <robh@...nel.org>, devicetree@...r.kernel.org,
 kernel@...electronics.com
Subject: Re: [net-next,PATCH v2] dt-bindings: net: realtek,rtl82xx: Document
 known PHY IDs as compatible strings

On 7/1/24 5:06 PM, Geert Uytterhoeven wrote:
> Hi Marek,

Hi,

> On Tue, Jun 25, 2024 at 8:46 PM Marek Vasut <marex@...x.de> wrote:
>> Extract known PHY IDs from Linux kernel realtek PHY driver
>> and convert them into supported compatible string list for
>> this DT binding document.
>>
>> Signed-off-by: Marek Vasut <marex@...x.de>
> 
> Thanks for your patch, which is now commit 8fda53719a596fa2
> ("dt-bindings: net: realtek,rtl82xx: Document known PHY IDs as
> compatible strings") in net-next/main (next-20240628 and later).
> 
>> --- a/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
>> +++ b/Documentation/devicetree/bindings/net/realtek,rtl82xx.yaml
>> @@ -18,6 +18,29 @@ allOf:
>>     - $ref: ethernet-phy.yaml#
>>
>>   properties:
>> +  compatible:
>> +    enum:
>> +      - ethernet-phy-id001c.c800
>> +      - ethernet-phy-id001c.c816
>> +      - ethernet-phy-id001c.c838
>> +      - ethernet-phy-id001c.c840
>> +      - ethernet-phy-id001c.c848
>> +      - ethernet-phy-id001c.c849
>> +      - ethernet-phy-id001c.c84a
>> +      - ethernet-phy-id001c.c862
>> +      - ethernet-phy-id001c.c878
>> +      - ethernet-phy-id001c.c880
>> +      - ethernet-phy-id001c.c910
>> +      - ethernet-phy-id001c.c912
>> +      - ethernet-phy-id001c.c913
>> +      - ethernet-phy-id001c.c914
>> +      - ethernet-phy-id001c.c915
>> +      - ethernet-phy-id001c.c916
>> +      - ethernet-phy-id001c.c942
>> +      - ethernet-phy-id001c.c961
>> +      - ethernet-phy-id001c.cad0
>> +      - ethernet-phy-id001c.cb00
> 
> Can you please elaborate why you didn't add an
> "ethernet-phy-ieee802.3-c22" fallback?

I'll quote Andrew's comment on

[PATCH 2/2] arm64: dts: renesas: Drop ethernet-phy-ieee802.3-c22 from 
PHY compatible string on all RZ boards

"
"ethernet-phy-ieee802.3-c22" is pretty much pointless. I don't
remember seeing a DT description which actually needs it. It is in the
binding more for completion, since "ethernet-phy-ieee802.3-c45" is
needed sometimes, and -c22 just completes the list.
"

But also, statistically, the in-kernel DTs contain both options, the one 
with "ethernet-phy-ieee802.3-c22" fallback is less common:

$ git grep -ho ethernet-phy-id001c....... | sort | uniq -c
       1 ethernet-phy-id001c.c816",
       2 ethernet-phy-id001c.c915",
       2 ethernet-phy-id001c.c915";
       5 ethernet-phy-id001c.c916",
      13 ethernet-phy-id001c.c916";