netdev - Re: [PATCH net v5] bonding: Fix out-of-bounds read in bond_option_arp_ip_targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240701143247.07bc17c9@kernel.org>
Date: Mon, 1 Jul 2024 14:32:47 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: 'Simon Horman' <horms@...nel.org>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>, Jay Vosburgh
 <j.vosburgh@...il.com>, Andy Gospodarek <andy@...yhouse.net>, Ding Tianhong
 <dingtianhong@...wei.com>, Hangbin Liu <liuhangbin@...il.com>, Sam Sun
 <samsun1006219@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net v5] bonding: Fix out-of-bounds read in
 bond_option_arp_ip_targets_set()

On Sun, 30 Jun 2024 14:20:55 +0100 'Simon Horman' wrote:
> +		if (!(strlen(newval->string)) ||

The extra brackets made me look, this really feels like it wants to be
written as:

	if (!newval->string[0] ||

or:

	if (strlen(newval->string) < 1 ||