netdev - Re: [PATCH v5 bpf-next 3/3] selftests/bpf: Add selftest for bpf_xdp_flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <66efa6eb-ed16-57b3-f490-8b3b4e6243f1@iogearbox.net>
Date: Mon, 1 Jul 2024 10:07:06 +0200
From: Daniel Borkmann <daniel@...earbox.net>
To: Lorenzo Bianconi <lorenzo@...nel.org>
Cc: bpf@...r.kernel.org, pablo@...filter.org, kadlec@...filter.org,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 pabeni@...hat.com, netfilter-devel@...r.kernel.org, netdev@...r.kernel.org,
 ast@...nel.org, andrii@...nel.org, martin.lau@...ux.dev, eddyz87@...il.com,
 lorenzo.bianconi@...hat.com, toke@...hat.com, fw@...len.de, hawk@...nel.org,
 horms@...nel.org, donhunte@...hat.com, memxor@...il.com
Subject: Re: [PATCH v5 bpf-next 3/3] selftests/bpf: Add selftest for
 bpf_xdp_flow_lookup kfunc

On 6/29/24 10:11 PM, Lorenzo Bianconi wrote:
>> On 6/14/24 5:40 PM, Lorenzo Bianconi wrote:
>> [...]
>>> +void test_xdp_flowtable(void)
>>> +{
>>> +	struct xdp_flowtable *skel = NULL;
>>> +	struct nstoken *tok = NULL;
>>> +	int iifindex, stats_fd;
>>> +	__u32 value, key = 0;
>>> +	struct bpf_link *link;
>>> +
>>> +	if (SYS_NOFAIL("nft -v")) {
>>> +		fprintf(stdout, "Missing required nft tool\n");
>>> +		test__skip();
>>> +		return;
>>
>> Bit unfortunate that upstream CI skips the test case at the moment:
> 
> yep, we are missing nft utility there.

Ok, not a blocker imho, but if you could work with Manu to get this
enabled in the CI, that would be great so that the test can actually
run.

Thanks,
Daniel