netdev - Re: [PATCH net] mlxsw: core_linecards: Fix double memory deallocation in case of invalid INI file

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c631fc5e-1cc6-467a-963a-69ef03c20f40@intel.com>
Date: Tue, 2 Jul 2024 12:50:41 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Aleksandr Mishin <amishin@...rgos.ru>, Jiri Pirko <jiri@...nulli.us>
CC: Ido Schimmel <idosch@...dia.com>, Petr Machata <petrm@...dia.com>, "David
 S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, "Jakub
 Kicinski" <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
	<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
	<lvc-project@...uxtesting.org>
Subject: Re: [PATCH net] mlxsw: core_linecards: Fix double memory deallocation
 in case of invalid INI file

On 7/2/24 12:33, Aleksandr Mishin wrote:
> In case of invalid INI file mlxsw_linecard_types_init() deallocates memory

IMO there should be some comment in the code indicating that invalid
file is not a critical error. I find it weird anyway that you ignore
invalid-file-error, but propagate ENOMEM.

> but doesn't reset pointer to NULL and returns 0. In case of any error
> occured after mlxsw_linecard_types_init() call, mlxsw_linecards_init()

typo: occurred

> calls mlxsw_linecard_types_fini() which perform memory deallocation again.
> 
> Add pointer reset to NULL.
> 
> Found by Linux Verification Center (linuxtesting.org) with SVACE.
> 
> Fixes: b217127e5e4e ("mlxsw: core_linecards: Add line card objects and implement provisioning")

this indeed avoids double free,
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>

> Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
> ---
>   drivers/net/ethernet/mellanox/mlxsw/core_linecards.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlxsw/core_linecards.c b/drivers/net/ethernet/mellanox/mlxsw/core_linecards.c
> index 025e0db983fe..b032d5a4b3b8 100644
> --- a/drivers/net/ethernet/mellanox/mlxsw/core_linecards.c
> +++ b/drivers/net/ethernet/mellanox/mlxsw/core_linecards.c
> @@ -1484,6 +1484,7 @@ static int mlxsw_linecard_types_init(struct mlxsw_core *mlxsw_core,
>   	vfree(types_info->data);
>   err_data_alloc:
>   	kfree(types_info);
> +	linecards->types_info = NULL;
>   	return err;
>   }
>   

BTW:
mlxsw_linecard_types_file_validate() don't need @types_info param