[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Message-Id: <20240702040518.11058-1-liujing@cmss.chinamobile.com>
Date: Tue, 2 Jul 2024 12:05:18 +0800
From: Liu Jing <liujing@...s.chinamobile.com>
To: matttbe@...nel.org,
martineau@...nel.org,
geliang@...nel.org,
davem@...emloft.net,
edumazet@...gle.com,
kuba@...nel.org,
pabeni@...hat.com,
shuah@...nel.org
Cc: netdev@...r.kernel.org,
mptcp@...ts.linux.dev,
linux-kselftest@...r.kernel.org,
linux-kernel@...r.kernel.org,
liujing@...s.chinamobile.com
Subject: [PATCH v2] selftests: mptcp: always close input's FD if opened
in main_loop_s function, when the open(cfg_input, O_RDONLY) function is run,
the last fd is not closed if the "--cfg_repeat > 0" branch is not taken.
Fixes: 05be5e273c84("selftests: mptcp: add disconnect tests").
Signed-off-by: Liu Jing <liujing@...s.chinamobile.com>
---
Changes from v1
- add close function in main_loop_s function
---
tools/testing/selftests/net/mptcp/mptcp_connect.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/testing/selftests/net/mptcp/mptcp_connect.c b/tools/testing/selftests/net/mptcp/mptcp_connect.c
index d2043ec3bf6d..48b7389ae75b 100644
--- a/tools/testing/selftests/net/mptcp/mptcp_connect.c
+++ b/tools/testing/selftests/net/mptcp/mptcp_connect.c
@@ -1119,7 +1119,8 @@ int main_loop_s(int listensock)
if (cfg_input)
close(fd);
goto again;
- }
+ } else
+ close(fd);
return 0;
}
--
2.33.0
Powered by blists - more mailing lists