[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20240702130247.18515-1-amishin@t-argos.ru>
Date: Tue, 2 Jul 2024 16:02:47 +0300
From: Aleksandr Mishin <amishin@...rgos.ru>
To: Michael Walle <michael@...le.cc>
CC: Aleksandr Mishin <amishin@...rgos.ru>, Andrew Lunn <andrew@...n.ch>,
Heiner Kallweit <hkallweit1@...il.com>, Russell King <linux@...linux.org.uk>,
"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
<netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
<lvc-project@...uxtesting.org>
Subject: [PATCH net v2] net: phy: mscc-miim: Validate bus frequency obtained from Device Tree
In mscc_miim_clk_set() miim->bus_freq is taken from Device Tree and can
contain any value in case of any error or broken DT. A value of 2147483648
multiplied by 2 will result in an overflow and division by 0.
Add bus frequency value check to avoid overflow.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Fixes: bb2a1934ca01 ("net: phy: mscc-miim: add support to set MDIO bus frequency")
Suggested-by: Michael Walle <michael@...le.cc>
Signed-off-by: Aleksandr Mishin <amishin@...rgos.ru>
---
v1->v2: Detect overflow event instead of using magic numbers as suggested by Michael
drivers/net/mdio/mdio-mscc-miim.c | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/net/mdio/mdio-mscc-miim.c b/drivers/net/mdio/mdio-mscc-miim.c
index c29377c85307..b344d0b03d8e 100644
--- a/drivers/net/mdio/mdio-mscc-miim.c
+++ b/drivers/net/mdio/mdio-mscc-miim.c
@@ -254,6 +254,11 @@ static int mscc_miim_clk_set(struct mii_bus *bus)
if (!miim->bus_freq)
return 0;
+ if (2 * miim->bus_freq == 0) {
+ dev_err(&bus->dev, "Incorrect bus frequency\n");
+ return -EINVAL;
+ }
+
rate = clk_get_rate(miim->clk);
div = DIV_ROUND_UP(rate, 2 * miim->bus_freq) - 1;
--
2.30.2
Powered by blists - more mailing lists