netdev - Re: [PATCH net v5] bonding: Fix out-of-bounds read in bond_option_arp_ip_targets

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240702134447.GA616664@kernel.org>
Date: Tue, 2 Jul 2024 14:44:47 +0100
From: Simon Horman <horms@...nel.org>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Jay Vosburgh <jay.vosburgh@...onical.com>,
	"David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
	Andy Gospodarek <andy@...yhouse.net>,
	Ding Tianhong <dingtianhong@...wei.com>,
	Hangbin Liu <liuhangbin@...il.com>,
	Sam Sun <samsun1006219@...il.com>, netdev@...r.kernel.org
Subject: Re: [PATCH net v5] bonding: Fix out-of-bounds read in
 bond_option_arp_ip_targets_set()

On Mon, Jul 01, 2024 at 07:59:08PM -0700, Jakub Kicinski wrote:
> On Mon, 01 Jul 2024 16:07:46 -0700 Jay Vosburgh wrote:
> > >	if (strlen(newval->string) < 1 ||  
> > 
> > 	I find the second option clearer, FWIW.  This isn't in a hot
> > path, and including strlen() in there makes it more obvious to my
> > reading what the intent is.  The size_t return from strlen() is
> > unsigned, so we really want to test the return value for zero-ness.
> 
> True, I picked < 1 because the line below offsets by 1.
> Either way is fine, but lets make sure we drop the parenthesis.

Thanks, I will go with < 1.