netdev - Re: [PATCH net-next] net: ethtool: fix compat with old RSS context API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3730656b-8bce-bba0-ae0a-7ada427abca0@gmail.com>
Date: Tue, 2 Jul 2024 18:35:48 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
 przemyslaw.kitszel@...el.com, andrew@...n.ch, ahmed.zaki@...el.com
Subject: Re: [PATCH net-next] net: ethtool: fix compat with old RSS context
 API

On 02/07/2024 17:41, Jakub Kicinski wrote:
> Device driver gets access to rxfh_dev, while rxfh is just a local
> copy of user space params. We need to check what RSS context ID
> driver assigned in rxfh_dev, not rxfh.
> 
> Using rxfh leads to trying to store all contexts at index 0xffffffff.
> From the user perspective it leads to "driver chose duplicate ID"
> warnings when second context is added and inability to access any
> contexts even tho they were successfully created - xa_load() for
> the actual context ID will return NULL, and syscall will return -ENOENT.
> 
> Looks like a rebasing mistake, since rxfh_dev was added relatively
> recently by fb6e30a72539 ("net: ethtool: pass a pointer to parameters
> to get/set_rxfh ethtool ops").
> 
> Fixes: eac9122f0c41 ("net: ethtool: record custom RSS contexts in the XArray")
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>

Reviewed-by: Edward Cree <ecree.xilinx@...il.com>

My bad, I should have re-tested that side of things after the rebase
 onto Ahmed's changes, instead of just testing the new API via sfc.
Thanks for catching it so quickly.