netdev - Re: [PATCH net v4] net: allow skb_datagram_iter to be called from any context

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2346b61ddecfca4d95a20415d27bdd8c50a83e9b.camel@redhat.com>
Date: Tue, 02 Jul 2024 11:51:46 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Sagi Grimberg <sagi@...mberg.me>, netdev@...r.kernel.org, Jakub Kicinski
	 <kuba@...nel.org>
Cc: Eric Dumazet <edumazet@...gle.com>, Matthew Wilcox <willy@...radead.org>
Subject: Re: [PATCH net v4] net: allow skb_datagram_iter to be called from
 any context

On Wed, 2024-06-26 at 13:00 +0300, Sagi Grimberg wrote:
> We only use the mapping in a single context, so kmap_local is sufficient
> and cheaper. Make sure to use skb_frag_foreach_page as skb frags may
> contain highmem compound pages and we need to map page by page.

My understanding of the discussion on previous revision is that Matthew
prefers dropping the reference to 'highmem':

https://lore.kernel.org/netdev/Zn1-2QVyOJe_y6l1@casper.infradead.org/#t

To avoid a repost, I can drop it while applying the patch, if there is
agreement.

Thanks,

Paolo