netdev - Re: [PATCH-next v1] r8152: Convert tasklet API to new bottom half workqueue mechanism

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240702184220.306d8085@kernel.org>
Date: Tue, 2 Jul 2024 18:42:20 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Anand Moon <linux.amoon@...il.com>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Paolo Abeni <pabeni@...hat.com>,
 linux-usb@...r.kernel.org, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH-next v1] r8152: Convert tasklet API to new bottom half
 workqueue mechanism

On Mon,  1 Jul 2024 15:33:27 +0530 Anand Moon wrote:
> Migrate tasklet APIs to the new bottom half workqueue mechanism. It
> replaces all occurrences of tasklet usage with the appropriate workqueue
> APIs throughout the alteon driver. This transition ensures compatibility
> with the latest design and enhances performance

alteon ?

> -		tasklet_enable(&tp->tx_tl);
> +		enable_and_queue_work(system_bh_wq, &tp->tx_work);

This is not obviously correct. Please explain why in the commit message
if you're sure this is right.
-- 
pw-bot: cr