netdev - Re: [PATCH net-next] ntp: fix size argument for kcalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5cafbf6e-37ad-4792-963e-568bcc20640d@intel.com>
Date: Wed, 3 Jul 2024 11:16:30 +0200
From: Przemek Kitszel <przemyslaw.kitszel@...el.com>
To: Chen Ni <nichen@...as.ac.cn>
CC: <oss-drivers@...igine.com>, <netdev@...r.kernel.org>,
	<linux-kernel@...r.kernel.org>, <louis.peens@...igine.com>,
	<kuba@...nel.org>, <davem@...emloft.net>, <edumazet@...gle.com>,
	<pabeni@...hat.com>, <horms@...nel.org>, <yinjun.zhang@...igine.com>,
	<johannes.berg@...el.com>, <ryno.swart@...igine.com>,
	<ziyang.chen@...igine.com>, <linma@....edu.cn>,
	<niklas.soderlund@...igine.com>
Subject: Re: [PATCH net-next] ntp: fix size argument for kcalloc

On 7/3/24 04:56, Chen Ni wrote:
> The size argument to kcalloc should be the size of desired structure,

xsk_pools is a double pointer, so not "desired structure" but rather you
should talk about an element size.

> not the pointer to it.
> 
> Fixes: 6402528b7a0b ("nfp: xsk: add AF_XDP zero-copy Rx and Tx support")

even if the the behavior is not changed, the fix should be targeted to
net tree

> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>   drivers/net/ethernet/netronome/nfp/nfp_net_common.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> index 182ba0a8b095..768f22cd3d02 100644
> --- a/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> +++ b/drivers/net/ethernet/netronome/nfp/nfp_net_common.c
> @@ -2539,7 +2539,7 @@ nfp_net_alloc(struct pci_dev *pdev, const struct nfp_dev_info *dev_info,
>   				  nn->dp.num_r_vecs, num_online_cpus());
>   	nn->max_r_vecs = nn->dp.num_r_vecs;
>   
> -	nn->dp.xsk_pools = kcalloc(nn->max_r_vecs, sizeof(nn->dp.xsk_pools),
> +	nn->dp.xsk_pools = kcalloc(nn->max_r_vecs, sizeof(*nn->dp.xsk_pools),
>   				   GFP_KERNEL);
>   	if (!nn->dp.xsk_pools) {
>   		err = -ENOMEM;

code change is correct, even if the size is the same
Reviewed-by: Przemek Kitszel <przemyslaw.kitszel@...el.com>