netdev - Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202407031841.Ww5ZFVKk-lkp@intel.com>
Date: Wed, 3 Jul 2024 19:17:25 +0800
From: kernel test robot <lkp@...el.com>
To: Lorenzo Bianconi <lorenzo@...nel.org>, netdev@...r.kernel.org
Cc: oe-kbuild-all@...ts.linux.dev, nbd@....name,
	lorenzo.bianconi83@...il.com, davem@...emloft.net,
	edumazet@...gle.com, kuba@...nel.org, pabeni@...hat.com,
	conor@...nel.org, linux-arm-kernel@...ts.infradead.org,
	robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org,
	conor+dt@...nel.org, devicetree@...r.kernel.org,
	catalin.marinas@....com, will@...nel.org, upstream@...oha.com,
	angelogioacchino.delregno@...labora.com,
	benjamin.larsson@...exis.eu, rkannoth@...vell.com,
	sgoutham@...vell.com, andrew@...n.ch, arnd@...db.de,
	horms@...nel.org
Subject: Re: [PATCH v4 2/2] net: airoha: Introduce ethernet support for
 EN7581 SoC

Hi Lorenzo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net/main]
[also build test WARNING on net-next/main linus/master v6.10-rc6]
[cannot apply to horms-ipvs/master next-20240703]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Lorenzo-Bianconi/dt-bindings-net-airoha-Add-EN7581-ethernet-controller/20240630-185836
base:   net/main
patch link:    https://lore.kernel.org/r/56f57f37b80796e9706555503e5b4cf194f69479.1719672695.git.lorenzo%40kernel.org
patch subject: [PATCH v4 2/2] net: airoha: Introduce ethernet support for EN7581 SoC
config: arm-randconfig-r123-20240703 (https://download.01.org/0day-ci/archive/20240703/202407031841.Ww5ZFVKk-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
reproduce: (https://download.01.org/0day-ci/archive/20240703/202407031841.Ww5ZFVKk-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202407031841.Ww5ZFVKk-lkp@intel.com/

sparse warnings: (new ones prefixed by >>)
>> drivers/net/ethernet/mediatek/airoha_eth.c:848:19: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __iomem *base @@     got struct airoha_eth *eth @@
   drivers/net/ethernet/mediatek/airoha_eth.c:848:19: sparse:     expected void [noderef] __iomem *base
   drivers/net/ethernet/mediatek/airoha_eth.c:848:19: sparse:     got struct airoha_eth *eth
   drivers/net/ethernet/mediatek/airoha_eth.c: note: in included file (through include/linux/mmzone.h, include/linux/gfp.h, include/linux/xarray.h, ...):
   include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false
   include/linux/page-flags.h:240:46: sparse: sparse: self-comparison always evaluates to false

vim +848 drivers/net/ethernet/mediatek/airoha_eth.c

   809	
   810	#define airoha_fe_rr(eth, offset)				\
   811		airoha_rr((eth)->fe_regs, (offset))
   812	#define airoha_fe_wr(eth, offset, val)				\
   813		airoha_wr((eth)->fe_regs, (offset), (val))
   814	#define airoha_fe_rmw(eth, offset, mask, val)			\
   815		airoha_rmw((eth)->fe_regs, (offset), (mask), (val))
   816	#define airoha_fe_set(eth, offset, val)				\
   817		airoha_rmw((eth)->fe_regs, (offset), 0, (val))
   818	#define airoha_fe_clear(eth, offset, val)			\
   819		airoha_rmw((eth)->fe_regs, (offset), (val), 0)
   820	
   821	#define airoha_qdma_rr(eth, offset)				\
   822		airoha_rr((eth)->qdma_regs, (offset))
   823	#define airoha_qdma_wr(eth, offset, val)			\
   824		airoha_wr((eth)->qdma_regs, (offset), (val))
   825	#define airoha_qdma_rmw(eth, offset, mask, val)			\
   826		airoha_rmw((eth)->qdma_regs, (offset), (mask), (val))
   827	#define airoha_qdma_set(eth, offset, val)			\
   828		airoha_rmw((eth)->qdma_regs, (offset), 0, (val))
   829	#define airoha_qdma_clear(eth, offset, val)			\
   830		airoha_rmw((eth)->qdma_regs, (offset), (val), 0)
   831	
   832	static void airoha_qdma_set_irqmask(struct airoha_eth *eth, int index,
   833					    u32 clear, u32 set)
   834	{
   835		unsigned long flags;
   836	
   837		if (WARN_ON_ONCE(index >= ARRAY_SIZE(eth->irqmask)))
   838			return;
   839	
   840		spin_lock_irqsave(&eth->irq_lock, flags);
   841	
   842		eth->irqmask[index] &= ~clear;
   843		eth->irqmask[index] |= set;
   844		airoha_qdma_wr(eth, REG_INT_ENABLE(index), eth->irqmask[index]);
   845		/* Read irq_enable register in order to guarantee the update above
   846		 * completes in the spinlock critical section.
   847		 */
 > 848		airoha_rr(eth, REG_INT_ENABLE(index));
   849	
   850		spin_unlock_irqrestore(&eth->irq_lock, flags);
   851	}
   852	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki