[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <377302f2-f081-9737-c0a8-8cffe2a5fcd0@gmail.com>
Date: Wed, 3 Jul 2024 12:16:48 +0100
From: Edward Cree <ecree.xilinx@...il.com>
To: Jakub Kicinski <kuba@...nel.org>, davem@...emloft.net
Cc: netdev@...r.kernel.org, edumazet@...gle.com, pabeni@...hat.com,
michael.chan@...adcom.com
Subject: Re: [PATCH net-next 02/11] net: ethtool: let drivers declare max size
of RSS indir table and key
On 03/07/2024 00:47, Jakub Kicinski wrote:
> Some drivers (bnxt but I think also mlx5 from ML discussions) change
> the size of the indirection table depending on the number of Rx rings.
> Decouple the max table size from the size of the currently used table,
> so that we can reserve space in the context for table growth.
>
> Static members in ethtool_ops are good enough for now, we can add
> callbacks to read the max size more dynamically if someone needs
> that.
>
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> ---
> include/linux/ethtool.h | 20 +++++++-----------
> net/ethtool/ioctl.c | 46 ++++++++++++++++++++++++++++++++---------
> 2 files changed, 44 insertions(+), 22 deletions(-)
>
> diff --git a/include/linux/ethtool.h b/include/linux/ethtool.h
> index 3ce5be0d168a..dc8ed93097c3 100644
> --- a/include/linux/ethtool.h
> +++ b/include/linux/ethtool.h
> @@ -173,6 +173,7 @@ static inline u32 ethtool_rxfh_indir_default(u32 index, u32 n_rx_rings)
> struct ethtool_rxfh_context {
> u32 indir_size;
> u32 key_size;
> + u32 key_off;
kdoc needed.
Other than that LGTM.
Powered by blists - more mailing lists